test(two-sisters): acceptance tests #625
Conversation
WalkthroughThe update introduces new configuration and step definitions for "Two Sisters Role" in a Cucumber.js environment. It includes a feature file detailing scenarios involving the Two Sisters role in a game, new step definitions for specific game interactions, and an update to the README file with a new section for this feature. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant System
participant TwoSistersRole
User->>System: Start Game
System->>TwoSistersRole: Initialize Two Sisters
User->>System: Set waking up interval
System->>TwoSistersRole: Update Interval
User->>System: Trigger meeting event
System->>TwoSistersRole: Handle Meeting
TwoSistersRole->>System: Meeting Outcome
System->>User: Display Outcome
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
tests/acceptance/screenshots/darwin/Two Sisters meet each other Playground.pngis excluded by!**/*.png
Files selected for processing (4)
- .run/Two Sisters Role.run.xml (1 hunks)
- tests/acceptance/features/game/features/role/two-sisters.feature (1 hunks)
- tests/acceptance/features/game/step-definitions/game-options/game-options.given-steps.ts (1 hunks)
- tests/acceptance/features/game/step-definitions/game-play/game-play.when-steps.ts (1 hunks)
Files skipped from review due to trivial changes (1)
- .run/Two Sisters Role.run.xml
Additional comments not posted (4)
tests/acceptance/features/game/features/role/two-sisters.feature (2)
5-50: LGTM! The scenario "Two sisters are called every other night" is well-defined.The steps are logically consistent and follow the expected game flow.
55-87: LGTM! The scenario "Two sisters are called every night when game master sets their waking up interval accordingly in game options" is well-defined.The steps are logically consistent and follow the expected game flow.
tests/acceptance/features/game/step-definitions/game-play/game-play.when-steps.ts (1)
123-124: LGTM! The step definition "When the two sisters meet each other" is well-implemented.The step correctly handles the game event by calling
makePlayInPlayground.tests/acceptance/features/game/step-definitions/game-options/game-options.given-steps.ts (1)
153-157: LGTM! The step definition "Given the user sets the two sisters waking up interval to (?\d+) in game options" is well-implemented.The step correctly handles the navigation and setting of the waking up interval in game options.
There was a problem hiding this comment.
Actionable comments posted: 1
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files ignored due to path filters (1)
tests/acceptance/screenshots/linux/Two Sisters meet each other Playground.pngis excluded by!**/*.png
Files selected for processing (1)
- README.md (1 hunks)
Additional context used
Markdownlint
README.md
193-193: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
194-194: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
195-195: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
196-196: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
198-198: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
200-200: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
201-201: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
202-202: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
203-203: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
204-204: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
| >> <summary>👯 Two Sisters meet each other Playground</summary> | ||
| >> | ||
| >>  | ||
| >> | ||
| >> </details> | ||
| >> <details> | ||
| >> <summary>🐺 Werewolves eat Playground</summary> | ||
| >> | ||
| >>  |
There was a problem hiding this comment.
Fix multiple spaces after blockquote symbols.
There are multiple spaces after blockquote symbols, which is against Markdownlint rules (MD027).
>> <details>
>> <summary>👯 Two Sisters meet each other Playground</summary>
>>
- >> 
+ >> 
>>
>> </details>Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| >> <summary>👯 Two Sisters meet each other Playground</summary> | |
| >> | |
| >>  | |
| >> | |
| >> </details> | |
| >> <details> | |
| >> <summary>🐺 Werewolves eat Playground</summary> | |
| >> | |
| >>  | |
| >> <details> | |
| >> <summary>👯 Two Sisters meet each other Playground</summary> | |
| >> | |
| >>  | |
| >> | |
| >> </details> | |
| >> <details> | |
| >> <summary>🐺 Werewolves eat Playground</summary> | |
| >> | |
| >>  |
Tools
Markdownlint
196-196: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
198-198: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
200-200: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
201-201: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
202-202: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
203-203: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
204-204: null
Multiple spaces after blockquote symbol(MD027, no-multiple-space-blockquote)
|
## [1.26.0](v1.25.0...v1.26.0) (2024-07-18) ### 🚀 Features * **game:** idiot spared life event ([#618](#618)) ([b5b77d1](b5b77d1)) * **game:** votes duration ([#646](#646)) ([d1384bb](d1384bb)) * **img:** add placeholder while images are loading ([#624](#624)) ([4d7419a](4d7419a)) * **pied-piper:** charmed people are revealed game option ([#639](#639)) ([05da133](05da133)) * **werewolf:** werewolf can eat each other game options ([#640](#640)) ([63923f3](63923f3)) ### 🐛 Bug Fixes * **deps:** update dependency @fortawesome/fontawesome-free to ^6.6.0 ([#643](#643)) ([c452a5d](c452a5d)) ### ✅ Tests * **three-brothers:** acceptance tests ([#626](#626)) ([b939bc1](b939bc1)) * **two-sisters:** acceptance tests ([#625](#625)) ([6bf5de2](6bf5de2)) ### 🧹 Chore * **deps:** update dependency @eslint/config-inspector to ^0.5.2 ([#647](#647)) ([9e7f69d](9e7f69d)) * **deps:** update dependency @nuxtjs/tailwindcss to ^6.12.1 ([#630](#630)) ([871619a](871619a)) * **deps:** update dependency eslint to ^9.7.0 ([#632](#632)) ([2a24fb9](2a24fb9)) * **deps:** update dependency husky to ^9.1.0 ([#648](#648)) ([67439d4](67439d4)) * **deps:** update dependency prettier to ^3.3.3 ([#633](#633)) ([299f29a](299f29a)) * **deps:** update dependency qs to ^6.12.3 ([#621](#621)) ([49cf119](49cf119)) * **deps:** update dependency rimraf to ^6.0.1 ([#629](#629)) ([7613fee](7613fee)) * **deps:** update dependency rimraf to v6 ([#623](#623)) ([6764092](6764092)) * **deps:** update dependency sass to ^1.77.7 ([#627](#627)) ([4f8f044](4f8f044)) * **deps:** update dependency sass to ^1.77.8 ([#631](#631)) ([442abf4](442abf4)) * **deps:** update dependency tailwindcss to ^3.4.5 ([#637](#637)) ([6ae364c](6ae364c)) * **deps:** update dependency tailwindcss to ^3.4.6 ([#642](#642)) ([87253ce](87253ce)) * **deps:** update dependency type-fest to ^4.22.0 ([#644](#644)) ([ae93b7b](ae93b7b)) * **deps:** update dependency vue to ^3.4.32 ([#645](#645)) ([b2e2084](b2e2084)) * **deps:** update node.js to >=20.15.1 ([#617](#617)) ([6629992](6629992)) * **deps:** update playwright monorepo to ^1.45.2 ([#641](#641)) ([152eb1a](152eb1a)) * **deps:** update pnpm to v9.5.0 ([#615](#615)) ([b84e26e](b84e26e)) * **deps:** update typescript-eslint monorepo to ^7.16.0 ([#619](#619)) ([6209cbe](6209cbe)) * **deps:** update typescript-eslint monorepo to ^7.16.1 ([#638](#638)) ([800d22c](800d22c)) * **deps:** update vitest monorepo to ^2.0.2 ([#628](#628)) ([a1d4940](a1d4940)) * **deps:** update vitest monorepo to v2 (major) ([#616](#616)) ([d5eb23f](d5eb23f)) * **locale:** improve some french i18n ([#649](#649)) ([2bbc1b4](2bbc1b4)) * **sandbox-api:** bump sandbox api version to 1-33-0 ([#635](#635)) ([8a10d59](8a10d59))
|
🎉 This PR is included in version 1.26.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary by CodeRabbit
New Features
Documentation