Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CheckableTag miss CP tag #44602

Merged
merged 4 commits into from
Sep 3, 2023
Merged

fix: CheckableTag miss CP tag #44602

merged 4 commits into from
Sep 3, 2023

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Sep 2, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Fix ConfigProvider tag.className & tag.style not working on Tag.CheckableTag.
🇨🇳 Chinese 修复 ConfigProvider tag.classNametag.style 无法作用于 Tag.CheckableTag 的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at e21907a

This pull request adds support for custom style and class name of the CheckableTag component from the ConfigProvider component. It also adds a test case and improves the code formatting of the related files.

🔍 Walkthrough

🤖 Generated by Copilot at e21907a

  • Add style prop to CheckableTag component and apply custom style and class name from ConfigProvider component (link, link, link, link)
  • Add Tag.CheckableTag component and assertions to test case should render style correctly in style.test.tsx to verify custom style and class name from ConfigProvider component (link, link, link)

@stackblitz
Copy link

stackblitz bot commented Sep 2, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 387.58 KB (+34 B 🔺)
./dist/antd-with-locales.min.js 446.63 KB (+25 B 🔺)

@argos-ci
Copy link

argos-ci bot commented Sep 2, 2023

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👍 Changes approved 1 change Sep 2, 2023, 5:15 PM

@afc163
Copy link
Member

afc163 commented Sep 2, 2023

https://app.argos-ci.com/ant-design/ant-design/builds/11214

这个截图测试极容易挂,得看看。

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (8099247) 100.00% compared to head (b616272) 100.00%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #44602   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          665       665           
  Lines        11280     11280           
  Branches      3049      3049           
=========================================
  Hits         11280     11280           
Files Changed Coverage Δ
components/tag/CheckableTag.tsx 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants