Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Menu migrate to @rc-component/trigger #42554

Merged
merged 6 commits into from
May 26, 2023
Merged

refactor: Menu migrate to @rc-component/trigger #42554

merged 6 commits into from
May 26, 2023

Conversation

MadCcc
Copy link
Member

@MadCcc MadCcc commented May 23, 2023

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

#41249

💡 Background and solution

image
干净了

📝 Changelog

Language Changelog
🇺🇸 English - Refactor Menu with @rc-component/trigger. - Remove rc-trigger and reduce bundle size.
🇨🇳 Chinese - 使用 @rc-component/trigger 重构 Menu 组件。 - 移除 rc-trigger 依赖,缩小打包体积。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

🚀 Summary

🤖 Generated by Copilot at 56fdcd8

This pull request improves the Menu component by updating its dependency rc-menu and refining its submenu theme demo.

🔍 Walkthrough

🤖 Generated by Copilot at 56fdcd8

  • Update rc-menu dependency to ~9.9.0 for bug fixes and improvements (link)
  • Adjust import order of React and antd components to follow ESLint rule import/order (link)
  • Remove getPopupContainer prop from Menu component as it is no longer needed after rc-menu refactoring (link)

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

@github-actions
Copy link
Contributor

github-actions bot commented May 23, 2023

size-limit report 📦

Path Size
./dist/antd.min.js 373.47 KB (-10.81 KB 🔽)
./dist/antd-with-locales.min.js 432.75 KB (-10.78 KB 🔽)

@yoyo837
Copy link
Contributor

yoyo837 commented May 23, 2023

在PR里一并缩小limit size?

@li-jia-nan
Copy link
Member

小这么多……

@socket-security
Copy link

New dependency changes detected. Learn more about Socket for GitHub ↗︎


👍 No new dependency issues detected in pull request

Bot Commands

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

Pull request alert summary
Issue Status
Install scripts ✅ 0 issues
Native code ✅ 0 issues
Bin script shell injection ✅ 0 issues
Unresolved require ✅ 0 issues
Invalid package.json ✅ 0 issues
HTTP dependency ✅ 0 issues
Git dependency ✅ 0 issues
Potential typo squat ✅ 0 issues
Known Malware ✅ 0 issues
Telemetry ✅ 0 issues
Protestware/Troll package ✅ 0 issues

📊 Modified Dependency Overview:

➕ Added Package Capability Access +/- Transitive Count Publisher
rc-mentions@2.3.0 None +1 madccc
rc-tabs@12.7.0 None +1 madccc

package.json Show resolved Hide resolved
@afc163
Copy link
Member

afc163 commented May 24, 2023

应该能关掉不少 issues,可以搜一下关联进来。

@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (81556c7) 100.00% compared to head (e64d93f) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##           feature    #42554   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          640       640           
  Lines        10865     10865           
  Branches      2955      2955           
=========================================
  Hits         10865     10865           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MadCcc MadCcc mentioned this pull request May 24, 2023
10 tasks
@afc163
Copy link
Member

afc163 commented May 24, 2023

这个 PR 的 changelog 可以好好写写

  1. 用什么方式重构了什么,底层依赖发生了什么变化
  2. 由此带来的体积变化
  3. 最终修复了哪些常见问题

@MadCcc MadCcc merged commit f09e9cb into feature May 26, 2023
@MadCcc MadCcc deleted the refactor/menu branch May 26, 2023 03:04
@MadCcc MadCcc mentioned this pull request Jun 6, 2023
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants