✨ feat: Breadcrumb Component Token #42342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems you are using me but didn't get OPENAI_API_KEY seted in Variables/Secrets for this repo. you could follow readme for more information |
|
|
51 tasks
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## feature #42342 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 619 640 +21
Lines 11048 10844 -204
Branches 3081 2945 -136
==========================================
- Hits 11048 10844 -204
☔ View full report in Codecov by Sentry. |
MadCcc
reviewed
May 17, 2023
| <!-- prettier-ignore --> | ||
| | Less 变量 | Component Token | 备注 | | ||
| | --- | --- | --- | | ||
| | `@drawer-bg` | `popoverBg` | - | |
There was a problem hiding this comment.
Suggested change
| | `@drawer-bg` | `popoverBg` | - | |
无关的 less 变量不用放进来
components/breadcrumb/style/index.ts
Outdated
Comment on lines
113
to
124
| baseColor: token.colorTextDescription, | ||
| lastItemColor: token.colorText, | ||
| iconFontSize: token.fontSize, | ||
| linkColor: token.colorTextDescription, | ||
| linkColorHover: token.colorText, | ||
| separatorColor: token.colorTextDescription, | ||
| separatorMargin: token.marginXS, |
There was a problem hiding this comment.
ComponentToken 要在 genComponentStyleHook 第三个参数初始化，不然会覆盖用户输入
components/breadcrumb/style/index.ts
Outdated
| baseColor: string; | ||
| iconFontSize: number; | ||
| linkColor: string; | ||
| linkColorHover: string; |
There was a problem hiding this comment.
Suggested change
| linkColorHover: string; | |
| linkHoverColor: string; |
components/breadcrumb/style/index.ts
Outdated
| breadcrumbSeparatorMargin: number; | ||
| breadcrumbSeparatorColor: string; | ||
| export interface ComponentToken { | ||
| baseColor: string; |
There was a problem hiding this comment.
Suggested change
| baseColor: string; | |
| itemColor: string; |
heiyu4585
force-pushed
the
Breadcrumb-token
branch
from
8fea043
to
a966cd8
Compare
MadCcc
reviewed
May 17, 2023
| ]} | ||
| /> | ||
| </ConfigProvider> | ||
| ); |
There was a problem hiding this comment.
最好能把所有 token 会改变的场景都列出来，现在 demo 里只能提现其中几个 token 的影响
heiyu4585
force-pushed
the
Breadcrumb-token
branch
from
6e22d10
to
40b5338
Compare
heiyu4585
force-pushed
the
Breadcrumb-token
branch
from
40b5338
to
36b5f1e
Compare
MadCcc
approved these changes
May 18, 2023
This was referenced May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[中文版模板 / Chinese template]
🤔 This is a ...
🔗 Related issue link
💡 Background and solution
#41884
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
🤖 Generated by Copilot at ef1cb5e
This pull request adds the
ComponentTokeninterface to the breadcrumb component, which allows the users to customize the component style through the ConfigProvider theme prop. It also updates the documentation and the migration guide to show how to use theComponentTokeninterface and how to map the Less variables to the ComponentToken values.🔍 Walkthrough
🤖 Generated by Copilot at ef1cb5e
genBreadcrumbStyleand the default export functions in thecomponents/breadcrumb/style/index.tsfile with the ComponentToken properties, to simplify the styling of the breadcrumb component (link, link, link, link, link, link)