Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump rc-picker to remove moment #38762

Merged
merged 1 commit into from
Nov 20, 2022
Merged

fix: bump rc-picker to remove moment #38762

merged 1 commit into from
Nov 20, 2022

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Nov 20, 2022

[中文版模板 / Chinese template]

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Other (about what?)

🔗 Related issue link

ref #38671 (comment)

💡 Background and solution

📝 Changelog

Language Changelog
🇺🇸 English Upgrading internal deps rc-picker whose deps still includes moment.
🇨🇳 Chinese 更新底层依赖 rc-picker 版本以移除残留 moment 依赖。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Changelog is provided or not needed

@github-actions
Copy link
Contributor

github-actions bot commented Nov 20, 2022

@github-actions
Copy link
Contributor

Size Change: 0 B

Total Size: 900 kB

ℹ️ View Unchanged
Filename Size
./dist/antd-with-locales.min.js 479 kB
./dist/antd.min.js 421 kB

compressed-size-action

@codecov
Copy link

codecov bot commented Nov 20, 2022

Codecov Report

Base: 100.00% // Head: 100.00% // No change to project coverage 👍

Coverage data is based on head (f116bcf) compared to base (3184448).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff            @@
##            master    #38762   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          544       544           
  Lines         9350      9350           
  Branches      2649      2649           
=========================================
  Hits          9350      9350           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zombieJ zombieJ merged commit cef8bf8 into master Nov 20, 2022
@zombieJ zombieJ deleted the picker branch November 20, 2022 15:18
This was referenced Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants