feat: refactoring create_temp_dir

doc/changelog.d/3239.miscellaneous.md

@@ -0,0 +1 @@
+feat: refactoring `create_temp_dir`

doc/source/api/pool.rst

@@ -1,7 +1,7 @@
 .. _ref_pool_api:
 
-Local MAPDL pool
-================
+MAPDL pool
+==========
 
 .. currentmodule:: ansys.mapdl.core
 

src/ansys/mapdl/core/misc.py

@@ -519,33 +519,27 @@
     """Create a new unique directory at a given temporary directory"""
     if tmpdir is None:
         tmpdir = tempfile.gettempdir()
-    elif not os.path.isdir(tmpdir):
-        os.makedirs(tmpdir)
 
-    if not name:
-        random_name = True
-        letters_ = string.ascii_lowercase.replace("n", "")
-        name = random_string(10, letters_)
-    else:
-        random_name = False
+    # Possible letters
+    letters_ = string.ascii_lowercase.replace("n", "")
 
-    # running into a rare issue with MAPDL on Windows with "\n" being
-    # treated literally.
-    path = os.path.join(tmpdir, name)
+    def get_name():
+        return random_string(10, letters_)
 
-    if random_name:
-        # in the *rare* case of a duplicate path
-        while os.path.isdir(path):
-            path = os.path.join(tempfile.gettempdir(), name)
+    name = name or get_name()
+    while os.path.exists(os.path.join(tmpdir, name)):
+        name = get_name()
 
-    if not os.path.exists(path):
-        try:
-            os.mkdir(path)
-        except:
-            raise MapdlRuntimeError(
-                "Unable to create temporary working "
-                f"directory {path}\nPlease specify 'run_location' argument"
-            )
+    # create dir:
+    path = os.path.join(tmpdir, name)
+
+    try:
+        os.mkdir(path)
+    except:
+        raise MapdlRuntimeError(
+            "Unable to create temporary working "
+            f"directory {path}\nPlease specify 'run_location' argument"
+        )
 
     return path
 

src/ansys/mapdl/core/pool.py

@@ -24,7 +24,6 @@
 import os
 import shutil
 import socket
-import tempfile
 import time
 from typing import Any, Dict, List, Optional, Union
 import warnings
@@ -219,7 +218,7 @@
         _debug_no_launch = kwargs.pop("_debug_no_launch", None)
 
         if run_location is None:
-            run_location = tempfile.gettempdir()
+            run_location = create_temp_dir()
         self._root_dir: str = run_location
 
         kwargs["remove_temp_files"] = remove_temp_files

tests/test_misc.py

@@ -23,6 +23,7 @@
 """Small or misc tests that don't fit in other test modules"""
 import inspect
 import os
+import pathlib
 
 import numpy as np
 import pytest
@@ -37,6 +38,7 @@
     check_valid_ip,
     check_valid_port,
     check_valid_routine,
+    create_temp_dir,
     last_created,
     load_file,
     no_return,
@@ -376,3 +378,15 @@ def test_check_valid_routine():
     assert check_valid_routine("begin level")
     with pytest.raises(ValueError, match="Invalid routine"):
         check_valid_routine("invalid")
+
+
+@requires("local")
+def test_create_temp_dir():
+
+    path = create_temp_dir()
+
+    path = pathlib.Path(path)
+    parent = path.parent
+    dir = path.parts[-1]
+
+    assert str(path) != create_temp_dir(parent, dir)