Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable-4.9] CI fixes #2126

Merged
merged 5 commits into from
May 1, 2024
Merged

[stable-4.9] CI fixes #2126

merged 5 commits into from
May 1, 2024

Conversation

bmclaughlin
Copy link
Contributor

No-Issue

What is this PR doing:

Issue: AAH-####

Reviewers must know:

PR Author & Reviewers: Keep or remove backport labels per Backporting Guidelines
Reviewers: Look for sound code, no code smells, docs & test coverage
Merger: When merging, include the Jira issue link in the squashed commit

@jctanner
Copy link
Collaborator

If we alter setup.py to pin galaxy-importer, we should run package=galaxy-importer make requirements/pip-upgrade-single-package to pin it in the requirements files also.

Also, we need to patch the ldap compose profile to set the ulimits to make sure the service comes up correctly ...

diff --git a/profiles/ldap/compose.yaml b/profiles/ldap/compose.yaml
index db5fa7e7..de710645 100644
--- a/profiles/ldap/compose.yaml
+++ b/profiles/ldap/compose.yaml
@@ -6,3 +6,7 @@ services:
     ports:
       - "10389:10389"
       - "10636:10636"
+    ulimits:
+      nofile:
+        soft: 65536
+        hard: 65536

With those two changes, all the ldap tests are passing for me locally.

@jctanner
Copy link
Collaborator

The pulp tests are failing because 891656c didn't update the relevant unit test.

@bmclaughlin bmclaughlin force-pushed the 4.9_ci branch 2 times, most recently from 7019f22 to 8166409 Compare April 22, 2024 14:02
@bmclaughlin bmclaughlin changed the title [stable-4.9] CI experiments [stable-4.9] CI fixes Apr 30, 2024
No-Issue

Signed-off-by: James Tanner <tanner.jc@gmail.com>
@bmclaughlin bmclaughlin marked this pull request as ready for review April 30, 2024 20:27
@bmclaughlin bmclaughlin merged commit 378f3de into ansible:stable-4.9 May 1, 2024
17 of 20 checks passed
@bmclaughlin bmclaughlin deleted the 4.9_ci branch May 1, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants