Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Accept SVG as avatar_url #2083

Merged
merged 1 commit into from
Feb 29, 2024
Merged

fix: Accept SVG as avatar_url #2083

merged 1 commit into from
Feb 29, 2024

Conversation

rochacbruno
Copy link
Member

@rochacbruno rochacbruno commented Feb 27, 2024 •
edited
Loading

Make download_avatar task to accept .svg up to 3MB

# pulpcore-manager download-namespace-logos --only-missing-sha
1 Namespaces missing avatar_sha256
nokia
Proceeding with namespace logo downloads
Process completed

# pulpcore-manager download-namespace-logos --sha-report
There are no namespaces missing avatar_sha256!

Also it will now fail the task if logo iamge is > 3MB or provided url is an invalid logo.
2024-02-28_17-25

Issue: AAH-2836

@github-actions github-actions bot added backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) backport-4.9 This PR should be backported to stable-4.9 (2.4) labels Feb 27, 2024
@rochacbruno rochacbruno force-pushed the aah-2836 branch 3 times, most recently from 827d6e6 to b3d8250 Compare February 27, 2024 18:19
@rochacbruno rochacbruno removed backport-4.2 This PR should be backported to stable-4.2 (1.2) backport-4.4 This PR should be backported to stable-4.4 (2.1) backport-4.5 This PR should be backported to stable-4.5 (2.2) backport-4.6 This PR should be backported to stable-4.6 (2.3) backport-4.7 This PR should be backported to stable-4.7 (2.4) backport-4.8 This PR should be backported to stable-4.8 (2.4) labels Feb 27, 2024
@rochacbruno rochacbruno force-pushed the aah-2836 branch 4 times, most recently from c9896aa to 8374dd9 Compare February 29, 2024 15:22
@rochacbruno
fix: Accept SVG as avatar_url
ae232f6 
Make download_avatar task to accept .svg up to 3MB

Issue: AAH-2836
@rochacbruno rochacbruno merged commit 0322587 into ansible:master Feb 29, 2024
28 checks passed
@rochacbruno rochacbruno deleted the aah-2836 branch February 29, 2024 17:25
@patchback Patchback
Copy link

patchback bot commented Feb 29, 2024 •
edited
Loading

Backport to stable-4.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/stable-4.9/032258766af553813fc616b4b4ee808aabe77f4f/pr-2083

Backported as #2088

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Feb 29, 2024
@rochacbruno @patchback
fix: Accept SVG as avatar_url (#2083)
e0bf711 
Make download_avatar task to accept .svg up to 3MB

Issue: AAH-2836
(cherry picked from commit 0322587)
@patchback patchback bot mentioned this pull request Feb 29, 2024
Merged
rochacbruno added a commit that referenced this pull request Feb 29, 2024
@patchback @rochacbruno
[PR #2083/03225876 backport][stable-4.9] fix: Accept SVG as avatar_url (
2fa9e74 
#2088)

fix: Accept SVG as avatar_url (#2083)

Make download_avatar task to accept .svg up to 3MB

Issue: AAH-2836
(cherry picked from commit 0322587)

Co-authored-by: Bruno Rocha <rochacbruno@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jctanner jctanner jctanner approved these changes

@newswangerd newswangerd Awaiting requested review from newswangerd

@bmclaughlin bmclaughlin Awaiting requested review from bmclaughlin

Assignees
No one assigned
Labels
backport-4.9 This PR should be backported to stable-4.9 (2.4)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rochacbruno @jctanner