fix: Add reset-failed state in executable_options #4301
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qalthos
requested review from
audgirka and
alisonlhart
and removed request for
a team
Qalthos
previously requested changes
Aug 28, 2024
|
+1 on Kate's comment, looks good besides needing the test case! |
tanwigeetika1618
force-pushed
the
fix-reset-failed
branch
from
52c85dd
to
2395762
Compare
|
audgirka
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Description:
This PR introduces a fix that allows the
reset-failedstate to be correctly handled when using theansible.builtin.commandmodule. Previously, the rule validation incorrectly flagged tasks usingsystemctl reset-failedthrough theansible.builtin.commandmodule, suggesting the use of thesystemdmodule instead, which does not natively support thereset-failedstate.Changes:
reset-failedstate in the executable options for theansible.builtin.commandmodule.