Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve logic of find_children #4161

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Improve logic of find_children #4161

merged 1 commit into from
Jun 4, 2024

Conversation

ssbarnea
Copy link
Member

@ssbarnea ssbarnea commented May 14, 2024

Address few bugs in our implementation of find_children, making it avoid errors when encountering unexpected data.

@ssbarnea ssbarnea requested a review from a team as a code owner May 14, 2024 13:58
@ssbarnea ssbarnea requested review from Qalthos and shatakshiiii and removed request for a team May 14, 2024 13:58
@github-actions github-actions bot added the bug label May 14, 2024
ssbarnea added a commit that referenced this pull request May 30, 2024
ssbarnea added a commit that referenced this pull request May 30, 2024
ssbarnea added a commit that referenced this pull request May 30, 2024
Address few bugs in our implementation of find_children, making it
avoid errors when encountering garbage data.
@ssbarnea ssbarnea merged commit d1ff289 into main Jun 4, 2024
24 of 25 checks passed
@ssbarnea ssbarnea deleted the fix/other branch June 4, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants