name[casing]: Add transform to automatically fix this during --write #3227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Markus Teufelberger <mteufelberger@mgit.at>
MarkusTeufelberger
requested review from
a team,
priyamsahoo,
shatakshiiii and
Ruchip16
|
Yeah, about that... How are transforms going/supposed to be tested? I suspect that I should re-do a few existing tests, but I'm unsure for example how to assert on the results. |
|
@MarkusTeufelberger #3268 implement your change. I was not able to fix this PR, probably because i did not have permission to push to your fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One of the easier rules for adding transforms I guess, but it is probably time to actually start doing it.
I didn't find any transformations being used (or tested) in the repo so far, but it seems to work and makes this rather annoying rewrite much easier.