Fix error suppression when syntax is incorrect (#4026)

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

.github/workflows/tox.yml

@@ -71,7 +71,7 @@ jobs:
     env:
       # Number of expected test passes, safety measure for accidental skip of
       # tests. Update value if you add/remove tests.
-      PYTEST_REQPASS: 852
+      PYTEST_REQPASS: 853
     steps:
       - uses: actions/checkout@v4
         with:

examples/playbooks/incorrect_module_args.yml

@@ -0,0 +1,7 @@
+---
+- name: Demonstrate linting issue.
+  hosts: all
+  tasks:
+    - name: Include a role with the wrong syntax
+      ansible.builtin.include_role:
+        role: foo

src/ansiblelint/runner.py

@@ -27,10 +27,6 @@
 
 import ansiblelint.skip_utils
 import ansiblelint.utils
-from ansiblelint._internal.rules import (
-    BaseRule,
-    LoadingFailureRule,
-)
 from ansiblelint.app import App, get_app
 from ansiblelint.constants import States
 from ansiblelint.errors import LintWarning, MatchError, WarnSource
@@ -40,16 +36,15 @@
 from ansiblelint.text import strip_ansi_escape
 from ansiblelint.utils import (
     PLAYBOOK_DIR,
-    _include_children,
-    _roles_children,
-    _taskshandlers_children,
+    HandleChildren,
     parse_examples_from_plugin,
     template,
 )
 
 if TYPE_CHECKING:
     from collections.abc import Callable, Generator
 
+    from ansiblelint._internal.rules import BaseRule
     from ansiblelint.config import Options
     from ansiblelint.constants import FileType
     from ansiblelint.rules import RulesCollection
@@ -458,7 +453,7 @@ def _emit_matches(self, files: list[Lintable]) -> Generator[MatchError, None, No
                 except MatchError as exc:
                     if not exc.filename:  # pragma: no branch
                         exc.filename = str(lintable.path)
-                    exc.rule = LoadingFailureRule()
+                    exc.rule = self.rules["load-failure"]
                     yield exc
                 except AttributeError:
                     yield MatchError(lintable=lintable, rule=self.rules["load-failure"])
@@ -523,22 +518,28 @@ def play_children(
     ) -> list[Lintable]:
         """Flatten the traversed play tasks."""
         # pylint: disable=unused-argument
-        delegate_map: dict[str, Callable[[str, Any, Any, FileType], list[Lintable]]] = {
-            "tasks": _taskshandlers_children,
-            "pre_tasks": _taskshandlers_children,
-            "post_tasks": _taskshandlers_children,
-            "block": _taskshandlers_children,
-            "include": _include_children,
-            "ansible.builtin.include": _include_children,
-            "import_playbook": _include_children,
-            "ansible.builtin.import_playbook": _include_children,
-            "roles": _roles_children,
-            "dependencies": _roles_children,
-            "handlers": _taskshandlers_children,
-            "include_tasks": _include_children,
-            "ansible.builtin.include_tasks": _include_children,
-            "import_tasks": _include_children,
-            "ansible.builtin.import_tasks": _include_children,
+
+        handlers = HandleChildren(self.rules)
+
+        delegate_map: dict[
+            str,
+            Callable[[str, Any, Any, FileType], list[Lintable]],
+        ] = {
+            "tasks": handlers.taskshandlers_children,
+            "pre_tasks": handlers.taskshandlers_children,
+            "post_tasks": handlers.taskshandlers_children,
+            "block": handlers.taskshandlers_children,
+            "include": handlers.include_children,
+            "ansible.builtin.include": handlers.include_children,
+            "import_playbook": handlers.include_children,
+            "ansible.builtin.import_playbook": handlers.include_children,
+            "roles": handlers.roles_children,
+            "dependencies": handlers.roles_children,
+            "handlers": handlers.taskshandlers_children,
+            "include_tasks": handlers.include_children,
+            "ansible.builtin.include_tasks": handlers.include_children,
+            "import_tasks": handlers.include_children,
+            "ansible.builtin.import_tasks": handlers.include_children,
         }
         (k, v) = item
         add_all_plugin_dirs(str(basedir.resolve()))