Skip to content
This repository has been archived by the owner on Jan 5, 2023. It is now read-only.

Fix #33 filter molecule_header, header or molecule_from_yaml missing #34

Merged

Conversation

aruntomar
Copy link
Contributor

This PR fixes the issue #33

As of molecule v3, ansible molecule filters have been removed.

@matusmalinka
Copy link

+1 for this commit
I've run into this issue few days ago.

@ssbarnea ssbarnea self-requested a review January 20, 2021 17:40
Copy link
Member

@ssbarnea ssbarnea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This review is not complete as it needs other changes, like adding sh module dependency or replacing it.

Ping me on irc when ready.

@tbugfinder
Copy link
Collaborator

Hi @aruntomar ,
would it be possile to finalize it?
After that I'm asking to carve out a new release so that new users don't have to start with invalid configs.

@aruntomar
Copy link
Contributor Author

hi @tbugfinder,

apologies for the delay. lately, I have been distracted and haven't focused. I'll try to fix it this weekend.

Arun

@aruntomar
Copy link
Contributor Author

@tbugfinder @ssbarnea All checks passing now. kindly review.

@ssbarnea ssbarnea merged commit 72d0653 into ansible-community:master Feb 21, 2021
jonashackt added a commit to jonashackt/molecule-ansible-docker-aws that referenced this pull request Feb 24, 2021
…dencies accordingly. But we have errors, see ansible/molecule#2946, https://github.com/ansible-community/molecule/pull/2869/files, ansible-community/molecule-ec2#34 (only merged 3 days ago). Also removed CircleCI for now, since the goal is to simply run every scenario on GHA.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants