-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync node labels and taints #4
Commits on Jan 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for eb49d0e - Browse repository at this point
Copy the full SHA eb49d0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for e958aab - Browse repository at this point
Copy the full SHA e958aabView commit details -
Configuration menu - View commit details
-
Copy full SHA for a9b011c - Browse repository at this point
Copy the full SHA a9b011cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7adff41 - Browse repository at this point
Copy the full SHA 7adff41View commit details
Commits on Jan 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5ad0b62 - Browse repository at this point
Copy the full SHA 5ad0b62View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7efecc1 - Browse repository at this point
Copy the full SHA 7efecc1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6355380 - Browse repository at this point
Copy the full SHA 6355380View commit details -
Fix RBAC roles for the K3OSConfig CR
It can now only handle these in its own namespace. The fix was to add `namespace=k3os-config-operator-system` to the RBAC markers for the CR.
Configuration menu - View commit details
-
Copy full SHA for d225ec2 - Browse repository at this point
Copy the full SHA d225ec2View commit details -
Add a Kubernetes clientset to the K3OSConfig reconciler
This is necessary in order to get secrets and update the nodes.
Configuration menu - View commit details
-
Copy full SHA for f0fc1b2 - Browse repository at this point
Copy the full SHA f0fc1b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for ad26193 - Browse repository at this point
Copy the full SHA ad26193View commit details -
Configuration menu - View commit details
-
Copy full SHA for 444c80b - Browse repository at this point
Copy the full SHA 444c80bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 54a85cd - Browse repository at this point
Copy the full SHA 54a85cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9cb6165 - Browse repository at this point
Copy the full SHA 9cb6165View commit details
Commits on Jan 6, 2021
-
Add initial implementation of node label reconciliation
This is still very much a work in progress.
Configuration menu - View commit details
-
Copy full SHA for b56dbac - Browse repository at this point
Copy the full SHA b56dbacView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b596b0 - Browse repository at this point
Copy the full SHA 7b596b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for d71bef1 - Browse repository at this point
Copy the full SHA d71bef1View commit details -
Configuration menu - View commit details
-
Copy full SHA for add5507 - Browse repository at this point
Copy the full SHA add5507View commit details -
Deserialize
hostname
from k3OS config YAMLI need this over in the picl-k3os-image-generator repository.
Configuration menu - View commit details
-
Copy full SHA for 4a1e433 - Browse repository at this point
Copy the full SHA 4a1e433View commit details
Commits on Jan 8, 2021
-
Configuration menu - View commit details
-
Copy full SHA for caddd48 - Browse repository at this point
Copy the full SHA caddd48View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3e367c8 - Browse repository at this point
Copy the full SHA 3e367c8View commit details -
Move k3OS node config YAML handling to the
pkg/nodes
packageThis will allow this code to be used outside of this project by using the operator as a library.
Configuration menu - View commit details
-
Copy full SHA for fdce6f1 - Browse repository at this point
Copy the full SHA fdce6f1View commit details -
Move constants to their own package
These are not constant in the Go sense of `const` but must be treated as constant. They’re structured so no one can update them outside of the `pkg` package.
Configuration menu - View commit details
-
Copy full SHA for c2f22f9 - Browse repository at this point
Copy the full SHA c2f22f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf1ae92 - Browse repository at this point
Copy the full SHA bf1ae92View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8fb0e7 - Browse repository at this point
Copy the full SHA a8fb0e7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 395911d - Browse repository at this point
Copy the full SHA 395911dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 411376e - Browse repository at this point
Copy the full SHA 411376eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2ec64ed - Browse repository at this point
Copy the full SHA 2ec64edView commit details -
Add
GetNodeName
to consts that hides where the node name is retriev……ed from For now it’s from the environment via the downward API but this might change and the reconciler should not care when this changes.
Configuration menu - View commit details
-
Copy full SHA for c31210b - Browse repository at this point
Copy the full SHA c31210bView commit details -
Wrap reconcile error that’s returned
This is another approach to handle terminal errors in a reconciler. For the case where an object was deleted (like the node, the secret or the K3OSConfig CR object) we have to return a nil error to the caller so that our reconciler isn’t called anymore. I might flesh this out more in the future with some functional options to configure the response error further. For now, this will do.
Configuration menu - View commit details
-
Copy full SHA for 7445488 - Browse repository at this point
Copy the full SHA 7445488View commit details -
Simplify and streamline logic to fetch node and node config in the re…
…conciler There’s now a couple more smaller methods to make this easier to read, understand and test.
Configuration menu - View commit details
-
Copy full SHA for 1fc081d - Browse repository at this point
Copy the full SHA 1fc081dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1fde51c - Browse repository at this point
Copy the full SHA 1fde51cView commit details -
Configuration menu - View commit details
-
Copy full SHA for 150b513 - Browse repository at this point
Copy the full SHA 150b513View commit details -
Configuration menu - View commit details
-
Copy full SHA for 11063bb - Browse repository at this point
Copy the full SHA 11063bbView commit details -
Configuration menu - View commit details
-
Copy full SHA for 84fbcd7 - Browse repository at this point
Copy the full SHA 84fbcd7View commit details -
Validate node name is set when starting the operator
This removes the need for the nasty panic I added earlier.
Configuration menu - View commit details
-
Copy full SHA for 0063b96 - Browse repository at this point
Copy the full SHA 0063b96View commit details -
Configuration menu - View commit details
-
Copy full SHA for f3fe16f - Browse repository at this point
Copy the full SHA f3fe16fView commit details -
Reattach the extracted getters to the reconciler struct
This cuts down on the amount of parameters these need to lug around.
Configuration menu - View commit details
-
Copy full SHA for 0038db6 - Browse repository at this point
Copy the full SHA 0038db6View commit details -
Extract updating the node resource into its own method
This way we can change the implementation of that and the rest of the code doesn’t need to care.
Configuration menu - View commit details
-
Copy full SHA for eb3b704 - Browse repository at this point
Copy the full SHA eb3b704View commit details -
Configure all the watches when building the reconciler
This creates metadata-only watches on our secret (filtered by the unique label it has) as well as the node the current instance is running on. It’s pretty light on the network and the memory but boy was this a pain to set up. 🤞 that it works correctly.
Configuration menu - View commit details
-
Copy full SHA for 60505e5 - Browse repository at this point
Copy the full SHA 60505e5View commit details -
Enable the new
LeaderElectionReleaseOnCancel
option on the managerWe’re using the context everywhere so enabling this should be safe.
Configuration menu - View commit details
-
Copy full SHA for 6581f2f - Browse repository at this point
Copy the full SHA 6581f2fView commit details -
Configuration menu - View commit details
-
Copy full SHA for d6f0256 - Browse repository at this point
Copy the full SHA d6f0256View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf875c2 - Browse repository at this point
Copy the full SHA bf875c2View commit details -
Switch leader election resource lock to leases only
This feature has been on by default since v1.14 and this operator was never deployed anywhere.
Configuration menu - View commit details
-
Copy full SHA for 52a8276 - Browse repository at this point
Copy the full SHA 52a8276View commit details -
Configuration menu - View commit details
-
Copy full SHA for 39991dc - Browse repository at this point
Copy the full SHA 39991dcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 70b9870 - Browse repository at this point
Copy the full SHA 70b9870View commit details -
Configuration menu - View commit details
-
Copy full SHA for c105f8a - Browse repository at this point
Copy the full SHA c105f8aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fe36bf3 - Browse repository at this point
Copy the full SHA fe36bf3View commit details -
Finish implementation of node taint reconciler
This includes about the same number of tests as the node label reconciler but the implementation is more complex because of the fact that taints have a lot more intricacies than labels.
Configuration menu - View commit details
-
Copy full SHA for 79496c0 - Browse repository at this point
Copy the full SHA 79496c0View commit details -
Clean up code that was mentioned in the review
This mostly deals with updates to comments and removing dead code.
Configuration menu - View commit details
-
Copy full SHA for b281432 - Browse repository at this point
Copy the full SHA b281432View commit details -
Add log statements in result error handler
This handles IsNotFound, IsGone and IsForbidden API server error responses.
Configuration menu - View commit details
-
Copy full SHA for 4cf2e0a - Browse repository at this point
Copy the full SHA 4cf2e0aView commit details