Add e2e test suite #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annismckenzie
force-pushed
the
add-e2e-test-suite
branch
4 times, most recently
from
d81450a
to
4237da4
Compare
annismckenzie
force-pushed
the
add-e2e-test-suite
branch
from
49ff3b6
to
a35739e
Compare
This completely replaces the configuration management that was kept in various places with constants for environment variable names and now there’s only once place to look for the configuration. The configuration is now also strictly passed to the components that need it so there’s no global config struct anywhere.
The whole feature was deprecated in the controller-runtime version v0.8.0 and turned out to be rather easy to remove.
This was fun to put together. It’s still rather rough around the edges and right now cares mostly about the happy path.
This was an oversight and was quick to add.
Previously I thought it’d be really hard to figure out whether updates were necessary but with some TDD it was easy even if it took some time.
annismckenzie
force-pushed
the
add-e2e-test-suite
branch
from
154f76d
to
8fe097a
Compare
annismckenzie
force-pushed
the
add-e2e-test-suite
branch
3 times, most recently
from
24cb8ee
to
49a1f72
Compare
annismckenzie
force-pushed
the
add-e2e-test-suite
branch
from
16bca77
to
b5e22ce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #27.
TODO: