Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(material/schematics): theming API migration not working with CRLF line endings #29171

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 3, 2024

Fixes that the migration didn't account for CRLF line endings when figuring out the Sass namespace.

Fixes #29147.

… line endings

Fixes that the migration didn't account for CRLF line endings when figuring out the Sass namespace.

Fixes angular#29147.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jun 3, 2024
@crisbeto crisbeto added the action: merge The PR is ready for merge by the caretaker label Jun 3, 2024
@crisbeto crisbeto merged commit c9e1d4a into angular:main Jun 3, 2024
23 of 25 checks passed
crisbeto added a commit that referenced this pull request Jun 3, 2024
… line endings (#29171)

Fixes that the migration didn't account for CRLF line endings when figuring out the Sass namespace.

Fixes #29147.

(cherry picked from commit c9e1d4a)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(schematic): Material migration for renamed functions/variables does not run
2 participants