fix(youtube-player): error when interacting with the player before the API has been loaded #29127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e API has been loaded Fixes a couple of issues: 1. We were using the `PlayerState` enum before the API has been loaded which will cause a runtime error because the enum is usually read off the `window`. 2. Fixes that calling the `playVideo` method wasn't load the YouTube API. Fixes angular#29030.
amysorto
approved these changes
May 28, 2024
crisbeto
added a commit
that referenced
this pull request
May 28, 2024
…e API has been loaded (#29127) Fixes a couple of issues: 1. We were using the `PlayerState` enum before the API has been loaded which will cause a runtime error because the enum is usually read off the `window`. 2. Fixes that calling the `playVideo` method wasn't load the YouTube API. Fixes #29030. (cherry picked from commit 883466e)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple of issues:
PlayerStateenum before the API has been loaded which will cause a runtime error because the enum is usually read off thewindow.playVideomethod wasn't load the YouTube API.Fixes #29030.