feat(material/core): move Material 3 support into stable #28913
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
force-pushed
the
m3-stable
branch
2 times, most recently
from
f5f6261
to
9bdca25
Compare
crisbeto
commented
Apr 19, 2024
| // Hue maps created from https://m3.material.io/theme-builder#/custom (using | ||
| // #984061 as source color). Not using predefined M3 palettes since some neutral | ||
| // hues are slightly off from generated theme. | ||
| const testM3ThemePalette = new Map([ |
There was a problem hiding this comment.
I had to move this palette into a separate function, because something in the test was mutating it causing random failures. Also has the nice side-effect of moving it to the bottom of the file.
crisbeto
requested review from
devversion,
josephperrott,
andrewseguin,
jelbourn and
mmalerba
as code owners
amysorto
approved these changes
Apr 19, 2024
guides/material-3.md
Outdated
| @@ -410,20 +403,19 @@ We recommend _not_ relying on the `color="primary"`, `color="accent"`, or `color | |||
| that are offered by a number of Angular Material components for M2 themes. However, if you want to | |||
| quickly update to M3 and are willing to accept the extra CSS generated for these variants, you can | |||
| enable backwards compatibility styles that restore the behavior of this API. Call the | |||
| `color-variants-back-compat` mixin from `@angular/material-experimental` with the M3 theme you want | |||
| `color-variants-backwards-compatibilityt` mixin from `@angular/material` with the M3 theme you want | |||
There was a problem hiding this comment.
Theres a small typo in this file, it should be color-variants-backwards-compatibility. Theres an extra t at the end
Moves all of the Material 3 theming APIs into stable since they'll be considered stable APIs in v18.
zarend
approved these changes
Apr 19, 2024
crisbeto
removed request for
jelbourn,
devversion,
josephperrott,
mmalerba,
andrewseguin and
wagnermaciel
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves all of the Material 3 theming APIs into stable since they'll be considered stable APIs in v18.