Backport ripple memory leak fix to LTS #28408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `MatRippleLoader` that is used in the button doesn't track any ripples, but instead patches the ripples onto the DOM nodes which in theory should avoid leaks since the ripple will be collected together with the node. The problem is that each ripple registers itself with the `RippleEventManager` which needs to be notified on destroy so that it can dereference the DOM nodes and remove the event listeners. These changes avoid the leaks by: 1. Destroying the ripple when the trigger is destroyed. 2. Cleaning up all the ripples when the ripple loader is destroyed. 3. No longer patching directives onto the DOM nodes. Fixes angular#28240. (cherry picked from commit a962bb7)
crisbeto
added
P3
crisbeto
requested review from
andrewseguin,
wagnermaciel,
mmalerba and
zarend
as code owners
andrewseguin
approved these changes
Jan 11, 2024
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports an existing fix from 17.0.x to 16.2.x.
The
MatRippleLoaderthat is used in the button doesn't track any ripples, but instead patches the ripples onto the DOM nodes which in theory should avoid leaks since the ripple will be collected together with the node. The problem is that each ripple registers itself with theRippleEventManagerwhich needs to be notified on destroy so that it can dereference the DOM nodes and remove the event listeners.These changes avoid the leaks by:
Fixes #28240.
(cherry picked from commit a962bb7)