This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
feat(ngAnimate): provide configuration support to match specific className values to trigger animations #5448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
…sName values to trigger animations Closes angular#5357 Closes angular#5283
| @@ -288,6 +288,11 @@ angular.module('ngAnimate', ['ng']) | |||
| }); | |||
| }); | |||
|
|
|||
| function isAcceptedClassName(className) { | |||
| var exp = $animateProvider.classNameFilter(); | |||
| return !(exp instanceof RegExp) || exp.test(className); | |||
There was a problem hiding this comment.
since the classNameFilter can be changed only during the config phase we should do this change once and generate either fn that always returns true or fn that runs the test.
|
otherwise lgtm |
|
Landed as cef084a. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5357
Closes #5283