Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

refactor($parse): clean up evaled function #5299

Closed
wants to merge 1 commit into from

Conversation

kseamon
Copy link
Contributor

@kseamon kseamon commented Dec 5, 2013

refactor($parse): clean up evaled function

Remove unused variables from the created function.
Use == null instead of (=== null || === undefined)
Don't wrap the evaled function in a closure when not unwrapping promises.
This change also brings a slight performance improvement: http://jsperf.com/optimizing-parse

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@ghost ghost assigned IgorMinar Dec 6, 2013
@petebacondarwin
Copy link
Member

@kseamon - there should be no capital letter at the start of the commit message subject.

Remove unused variables from the created function.
Use == null instead of (=== null || === undefined)
Don't wrap the evaled function in a closure when not unwrapping promises.
This change also brings a slight performance improvement: http://jsperf.com/optimizing-parse
@IgorMinar
Copy link
Contributor

I'm sorry, but I wasn't able to verify your CLA signature. CLA signature is required for any code contributions to AngularJS.

Please sign our CLA and ensure that the CLA signature email address and the email address in this PR's commits match.

If you signed the CLA as a corporation, please let me know the company's name.

Thanks a bunch!

PS: If you signed the CLA in the past then most likely the email addresses don't match. Please sign the CLA again or update the email address in the commit of this PR.
PS2: If you are a Googler, please sign the CLA as well to simplify the CLA verification process.

@ghost ghost assigned jeffbcross Dec 9, 2013
@kseamon
Copy link
Contributor Author

kseamon commented Dec 10, 2013

This PR is obsoleted by #5359

@kseamon kseamon closed this Dec 10, 2013
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants