This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
Animation Fixes #4742
Closed
Animation Fixes #4742
+645
−476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
| @@ -9,3 +9,6 @@ | |||
| ng\:form { | |||
| display: block; | |||
| } | |||
|
|
|||
| .ng-animate { clip:rect(1px, 0, auto, auto); } | |||
There was a problem hiding this comment.
can you add a comment with explanation of why this is here
There was a problem hiding this comment.
also please verify that the comment is stripped from the string inlined into angular.js (it should be)
There was a problem hiding this comment.
/* The clip property will ensure that the CSS transition will
- ALWAYS animate something when transitions are performed using
- ngAnimate + $animate. If a CSS transition doesn't have any
- transition properties to transition to then it will hang until a
- new style is changed. The clip style is a highly underused property
- and is only visible on screen if position=absolute|fixed is used. */
There was a problem hiding this comment.
And yes it does get stripped.
|
lgtm |
|
The message for the |
…ass definitions BREAKING CHANGE ngAnimate addClass / removeClass animations are now applied right away. This means that as soon as the animation starts the class will be added (addClass) or removed (removeClass) to the element being animated instead of after the -add-active / -remove-active animations are completed. This allows for animations outside of ngAnimate to not conflict with $animate. This commit introduces beforeAddClass and beforeRemoveClass animation event functions and executes any addClass and removeClass event functions AFTER the class has been added or removed (this is opposite functionality of how ngAnimate used to work when performing JS-enabled animations addClass / removeClass animations). If your animation code relies on any animations being performed prior to the class change then simply use the new beforeAddClass and beforeRemoveClass animation event functions. Finally ng-hide-remove doesn't require display:block!important anymore and that must be placed on ng-hide-add instead if you plan on animating show and hide animations using CSS transitions or keyframe animations.
|
I made the changes and landed this PR |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.