Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

fix(location): check for existence before using #4443

Closed
wants to merge 1 commit into from
Closed

fix(location): check for existence before using #4443

wants to merge 1 commit into from

Conversation

eddiemonge
Copy link
Contributor

Check to see if the value exists before attempting to use it to avoid throwing unnecessary errors

Partially fixes #4442

@mary-poppins
Copy link

Thanks for the PR!

  • Contributor signed CLA now or in the past
    • If you just signed, leave a comment here with your real name
  • PR's commit messages follow the commit message format

If you need to make changes to your pull request, you can update the commit with git commit --amend.
Then, update the pull request with git push -f.

Thanks again for your help!

@eddiemonge
Copy link
Contributor Author

Is it possible to have @mary-poppins auto check the cla list and update its message based on that?

Check to see if the value exists before attempting to use it

Partially fixes #4442
@petebacondarwin
Copy link
Member

@eddiemonge - sorry Mary isn't allowed to see the CLA list yet. It is an internal Google document.

@petebacondarwin
Copy link
Member

@eddiemonge - This fix will need a unit test to demonstrate the issue before it can be merged.

@petebacondarwin
Copy link
Member

@eddiemonge - Actually this is not an appropriate fix. beginsWith should not be passed undefined in the url parameter and neither should $$parse. The real problem in #4442 is that $$rewrite should never be returning undefined.

@eddiemonge eddiemonge deleted the patch-1 branch November 2, 2013 17:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

angular ngRoute breaks when using base tag
3 participants