fix(required): `false` is a valid model value for required <select> #3658

lgalfaso · 2013-08-19T17:16:58Z

Make the required directive accept the model value false when it is not an element.

vojtajina · 2013-09-05T18:36:29Z

src/ng/directive/input.js

@@ -1228,14 +1228,15 @@ var requiredDirective = function() {
      attr.required = true; // force truthy in case we are on non input element

      var validator = function(value) {
-        if (attr.required && (isEmpty(value) || value === false)) {
+        if (attr.required && (isEmpty(value) || !acceptFalse && value === false)) {


Why this condition ? why is false invalid for inputs ?

vojtajina · 2013-09-05T18:37:52Z

Thanks @lgalfaso. This change makes sense to me.

I only don't understand why we need to treat false specially on inputs.

lgalfaso · 2013-09-05T18:53:17Z

Hi @vojtajina, input of type checkbox can have the values true or false. When ng-required is placed on an input of type checkbox, this implies that the checkbox must be checked

Make the `required` directive accept the model value `false` when it is not an <input> element or when the <input> element is not a checkbox Closes angular#3490 angular#2594

petebacondarwin · 2013-09-25T12:23:23Z

@lgalfaso and @vojtajina - Can you take a look at this alternate solution to these problems?
#4153

`checkboxInputType` and `ngList` directives need to have special logic for whether they are empty or not. Previously this had been hard coded into their own directives or the `ngRequired` directive. This made it difficult to handle these special cases. This change factors out the question of whether an input is empty into a method `$isEmpty` on the `ngModelController`. The `ngRequired` directive now uses this method when testing for validity and directives, such as `checkbox` or `ngList` can override it to apply logic specific to their needs. Closes angular#3490, angular#3658, angular#2594

petebacondarwin · 2013-10-03T07:53:26Z

Moving discussion to #4153

`checkboxInputType` and `ngList` directives need to have special logic for whether they are empty or not. Previously this had been hard coded into their own directives or the `ngRequired` directive. This made it difficult to handle these special cases. This change factors out the question of whether an input is empty into a method `$isEmpty` on the `ngModelController`. The `ngRequired` directive now uses this method when testing for validity and directives, such as `checkbox` or `ngList` can override it to apply logic specific to their needs. Closes angular#3490, angular#3658, angular#2594

ghost assigned mhevery Aug 27, 2013

vojtajina reviewed Sep 5, 2013
View reviewed changes

ghost assigned vojtajina Sep 5, 2013

fix(required): false is a valid model value when not a checkbox

2575b57

Make the `required` directive accept the model value `false` when it is not an <input> element or when the <input> element is not a checkbox Closes angular#3490 angular#2594

petebacondarwin mentioned this pull request Sep 25, 2013

fix(input): false is no longer an empty value by default #4153

Closed

petebacondarwin closed this Oct 3, 2013

google-admin unassigned vojtajina Mar 26, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(required): `false` is a valid model value for required <select> #3658

fix(required): `false` is a valid model value for required <select> #3658

lgalfaso commented Aug 19, 2013

vojtajina Sep 5, 2013

vojtajina commented Sep 5, 2013

lgalfaso commented Sep 5, 2013

petebacondarwin commented Sep 25, 2013

petebacondarwin commented Oct 3, 2013

fix(required): false is a valid model value for required <select> #3658

fix(required): false is a valid model value for required <select> #3658

Conversation

lgalfaso commented Aug 19, 2013

vojtajina Sep 5, 2013

Choose a reason for hiding this comment

vojtajina commented Sep 5, 2013

lgalfaso commented Sep 5, 2013

petebacondarwin commented Sep 25, 2013

petebacondarwin commented Oct 3, 2013

fix(required): `false` is a valid model value for required <select> #3658

fix(required): `false` is a valid model value for required <select> #3658