This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
bug-fix for ng-list directive #1839
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Failed.(Expected 'x,y,z' be 'x, y, z')
|
I am not able to understand the cause of build failure. |
|
@ashishgithub Travis-CI is unstable at the moment, we don't know what is the root cause as of now. So I don't think that the build failure is linked to your change. Having said this, I had a look at your pull request and it will need tests before it can be considered for merging. Also you will need amend a commit message to sign the CLA. Details are here: http://docs.angularjs.org/misc/contribute |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : ng-list directive overrides user specified separator by comma separator.
Resolution : Corrected the code of ng-list directive.