ngAnimate throws errors (leaves stale items) for ngRepeat with nested ngInclude

[alexjc]

The title describes the bug well enough I think, and here's my local hack to fix it:

index 64be7ba..7ef8d6d 100644
--- a/src/ngAnimate/animate.js
+++ b/src/ngAnimate/animate.js
@@ -256,6 +256,8 @@ angular.module('ngAnimate', ['ng'])
     var selectors = $animateProvider.$$selectors;

     var ELEMENT_NODE = 1;
+    var ELEMENT_DOCUMENTATION = 8;
+
     var NG_ANIMATE_STATE = '$$ngAnimateState';
     var NG_ANIMATE_CLASS_NAME = 'ng-animate';
     var rootAnimateState = {disabled:true};
@@ -883,6 +885,13 @@ angular.module('ngAnimate', ['ng'])
           startTime = Date.now(),
           node = element[0];

+          // When using ng-include within an ng-repeat, it's not always the first
+          // child element, that's a comment inserted by ng-include.  In the case
+          // if this node is a comment, get the next one.
+          if (node.nodeType == ELEMENT_DOCUMENTATION) {
+            node = element[1];
+          }
+
       //temporarily disable the transition so that the enter styles
       //don't animate twice (this is here to avoid a bug in Chrome/FF).
       if(timings.transitionDuration > 0) {

If this looks sensible to you let me know and I can submit a pull request. If not, let me know ;-)

Alex

[wesleycho]

If it is a comment though, couldn't it be something from ng-if, or ng-repeat?

[alexjc]

Yes, ng-repeat uses comments heavily but it's not the problem. I have an ng-repeat on its own elsewhere and obviously it works -- or it would have been reported already :-).

For me ng-include leaves comments like this:

<!-- ngInclude:  -->

Having that within the repeater, on the same div, confuses ngAnimation. It's the fix I submitted, you need to get the next element to have the actual ng-included item.

(It's my first bug report / fix here, I hope I'm making sense.)

[matsko]

Can you provide a plunkr please? I responded to an issue earlier today which may be related to this.

[alexjc]

http://plnkr.co/edit/sVhmdeqsVx3XfiNCbtS8

Sorry for the delay, it took a bit of time to set up a minimal example. Click on the button and watch the console for the exception.

EDIT: There were two bugs I had to fix in RC3 to get it working, but in the trunk of AngularJS you already fixed one. You may have to use that fix and the latest code to get to the second -- posted above.

[matsko]

What is the other bug? The comment exception one was fixed with: b9557b0

[alexjc]

The other bug is fixed by my diff above.

[matsko]

OK cool. I see what's going on. I'm working on a bigger commit so I'll add that one in.

[matsko]

Fixed: https://s3.amazonaws.com/angularjs-dev/ng-animate-comment-nodes/example/animate.html