Skip to content
This repository has been archived by the owner on Apr 12, 2024. It is now read-only.

Using the HTTP PATCH method with $http results in a "Invalid argument" exception on IE8 #2518

Closed
saebyn opened this issue Apr 26, 2013 · 1 comment · Fixed by #5390
Closed

Using the HTTP PATCH method with $http results in a "Invalid argument" exception on IE8 #2518

saebyn opened this issue Apr 26, 2013 · 1 comment · Fixed by #5390

Comments

@saebyn
Copy link

saebyn commented Apr 26, 2013

When passing a config object with a 'PATCH' method to the $http service, an "Invalid argument" exception is thrown in Internet Explorer 8. I've tested with AngularJS version 1.0.5 and this problem seems to be present in the master branch as well.

window.XMLHttpRequest in IE8 doesn't support the PATCH method, but the ActiveX objects do - I'm currently working around this by checking for their availability first and then defaulting back to window.XMLHttpRequest rather than the current behavior which goes in the opposite direction.
@btford btford closed this as completed Aug 24, 2013
@btford
Copy link
Contributor

btford commented Aug 24, 2013

As part of our effort to clean out old issues, this issue is being automatically closed since it has been inactivite for over two months.

Please try the newest versions of Angular (1.0.8 and 1.2.0-rc.1), and if the issue persists, comment below so we can discuss it.

Thanks!

@jeffsmohan jeffsmohan mentioned this issue Nov 20, 2013
Closed
IgorMinar added a commit to IgorMinar/angular.js that referenced this issue Dec 13, 2013
@IgorMinar
fix($httpBackend): use ActiveX XHR when making PATCH requests on IE8
889a9f2 
IE8's native XHR doesn't support PATCH requests, but the ActiveX one does.

Closes angular#2518
Closes angular#5043
@IgorMinar IgorMinar mentioned this issue Dec 13, 2013
Merged
wesleycho pushed a commit to wesleycho/angular.js that referenced this issue Dec 31, 2013
@IgorMinar @wesleycho
fix($httpBackend): use ActiveX XHR when making PATCH requests on IE8
0549e04 
IE8's native XHR doesn't support PATCH requests, but the ActiveX one does.

Closes angular#2518
Closes angular#5043

Fixed createXhr function to throw minErr when an exception occurs
wesleycho pushed a commit to wesleycho/angular.js that referenced this issue Dec 31, 2013
@IgorMinar @wesleycho
fix($httpBackend): use ActiveX XHR when making PATCH requests on IE8
681b10c 
IE8's native XHR doesn't support PATCH requests, but the ActiveX one does.

Closes angular#2518
Closes angular#5043
@wesleycho wesleycho mentioned this issue Dec 31, 2013
Closed
IgorMinar added a commit to IgorMinar/angular.js that referenced this issue Jan 3, 2014
@IgorMinar
fix($httpBackend): use ActiveX XHR when making PATCH requests on IE8
6c17d02 
IE8's native XHR doesn't support PATCH requests, but the ActiveX one does.

I'm also removing the noxhr error doc because nobody will ever get that error.

Closes angular#2518
Closes angular#5043
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@IgorMinar @jamesdaily
fix($httpBackend): use ActiveX XHR when making PATCH requests on IE8
6680b99 
IE8's native XHR doesn't support PATCH requests, but the ActiveX one does.

I'm also removing the noxhr error doc because nobody will ever get that error.

Closes angular#2518
Closes angular#5043
jamesdaily pushed a commit to jamesdaily/angular.js that referenced this issue Jan 27, 2014
@IgorMinar @jamesdaily
fix($httpBackend): use ActiveX XHR when making PATCH requests on IE8
5f6454b 
IE8's native XHR doesn't support PATCH requests, but the ActiveX one does.

I'm also removing the noxhr error doc because nobody will ever get that error.

Closes angular#2518
Closes angular#5043
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@saebyn @btford