feat($cookieStore): $cookieStore.get now parses blank string as blank…

… string closes #1918
angular · May 8, 2013 · cf4729f · cf4729f
1 parent 4f2e360
commit cf4729f
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/src/ngCookies/cookies.js b/src/ngCookies/cookies.js
@@ -139,7 +139,8 @@ angular.module('ngCookies', ['ng']).
          * @returns {Object} Deserialized cookie value.
          */
         get: function(key) {
-          return angular.fromJson($cookies[key]);
+          var value = $cookies[key];
+          return value ? angular.fromJson(value) : value;
         },
 
         /**

diff --git a/test/ngCookies/cookiesSpec.js b/test/ngCookies/cookiesSpec.js
@@ -125,4 +125,15 @@ describe('$cookieStore', function() {
     $rootScope.$digest();
     expect($browser.cookies()).toEqual({});
   }));
+  it('should handle empty string value cookies', inject(function ($cookieStore, $browser, $rootScope) {
+    $cookieStore.put("emptyCookie",'');
+    $rootScope.$digest();
+    expect($browser.cookies()).
+        toEqual({ 'emptyCookie': '""' });
+    expect($cookieStore.get("emptyCookie")).toEqual('');
+
+    $browser.cookieHash['blankCookie'] = '';
+    $browser.poll();
+    expect($cookieStore.get("blankCookie")).toEqual('');
+  }))
 });