fix(jqlite): removeClass would clobber class names

angular · Oct 11, 2011 · b96e978 · b96e978
1 parent bda2bba
commit b96e978
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/src/jqLite.js b/src/jqLite.js
@@ -208,8 +208,8 @@ function JQLiteData(element, key, value) {
 function JQLiteHasClass(element, selector, _) {
   // the argument '_' is important, since it makes the function have 3 arguments, which
   // is needed for delegate function to realize the this is a getter.
-  var className = " " + selector + " ";
-  return ((" " + element.className + " ").replace(/[\n\t]/g, " ").indexOf( className ) > -1);
+  return ((" " + element.className + " ").replace(/[\n\t]/g, " ").
+      indexOf( " " + selector + " " ) > -1);
 }
 
 function JQLiteRemoveClass(element, selector) {

diff --git a/test/jqLiteSpec.js b/test/jqLiteSpec.js
@@ -318,10 +318,16 @@ describe('jqLite', function(){
     describe('removeClass', function(){
       it('should allow removal of class', function(){
         var selector = jqLite([a, b]);
+        selector.addClass('a');
+        selector.addClass('b');
+        selector.addClass('c');
         expect(selector.addClass('abc')).toEqual(selector);
         expect(selector.removeClass('abc')).toEqual(selector);
         expect(jqLite(a).hasClass('abc')).toEqual(false);
         expect(jqLite(b).hasClass('abc')).toEqual(false);
+        expect(jqLite(a).hasClass('a')).toEqual(true);
+        expect(jqLite(a).hasClass('b')).toEqual(true);
+        expect(jqLite(a).hasClass('c')).toEqual(true);
       });