fix(dateFilter): allow negative millisecond value strings

angular · Oct 1, 2013 · 025c921 · 025c921
1 parent ac2d06b
commit 025c921
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/ng/filter/filters.js b/src/ng/filter/filters.js
@@ -260,7 +260,7 @@ var DATE_FORMATS = {
 };
 
 var DATE_FORMATS_SPLIT = /((?:[^yMdHhmsaZE']+)|(?:'(?:[^']|'')*')|(?:E+|y+|M+|d+|H+|h+|m+|s+|a|Z))(.*)/,
-    NUMBER_STRING = /^\d+$/;
+    NUMBER_STRING = /^\-?\d+$/;
 
 /**
  * @ngdoc filter

diff --git a/test/ng/filter/filtersSpec.js b/test/ng/filter/filtersSpec.js
@@ -246,6 +246,10 @@ describe('filters', function() {
                       toEqual('September 03, 1');
     });
 
+    it('should accept negative numbers as strings', function() {
+      expect(date('-1')).toEqual('Dec 31, 1969');
+    });
+
     it('should format timezones correctly (as per ISO_8601)', function() {
       //Note: TzDate's first argument is offset, _not_ timezone.
       var utc       = new angular.mock.TzDate( 0, '2010-09-03T12:05:08.000Z');