Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@schematics/angular): adjust block comment #19585

Merged
merged 1 commit into from
Dec 15, 2020
Merged

fix(@schematics/angular): adjust block comment #19585

merged 1 commit into from
Dec 15, 2020

Conversation

oleksiipotiekhin-zz
Copy link

@oleksiipotiekhin-zz oleksiipotiekhin-zz commented Dec 10, 2020

https://github.com/Microsoft/tslint-microsoft-contrib

ERROR: 21:1 no-single-line-block-comment Replace block comment with a single-line comment

@google-cla google-cla bot added the cla: yes label Dec 10, 2020
@alan-agius4 alan-agius4 added action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews target: patch This PR is targeted for the next patch release labels Dec 11, 2020
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oleksiipotiekhin, thanks for this change. Can you please squash the commits? Otherwise LGTM.

https://github.com/Microsoft/tslint-microsoft-contrib

ERROR: 21:1 no-single-line-block-comment Replace block comment with a single-line comment
@oleksiipotiekhin-zz oleksiipotiekhin-zz changed the title fix(@schematics/angular) replace block comment with a single-line comment fix(@schematics/angular): adjust block comment Dec 11, 2020
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: cleanup The PR is in need of cleanup, either due to needing a rebase or in response to comments from reviews labels Dec 11, 2020
@filipesilva filipesilva merged commit f73a878 into angular:master Dec 15, 2020
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jan 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants