Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

$onInit is called twice when componentProvider is used #3735

Closed
1 of 3 tasks
valterkraemer opened this issue Aug 14, 2018 · 2 comments
Closed
1 of 3 tasks

$onInit is called twice when componentProvider is used #3735

valterkraemer opened this issue Aug 14, 2018 · 2 comments
Labels
stale

Comments

@valterkraemer
Copy link

This is a:

  • Bug Report
  • Feature Request
  • General Query

My version of UI-Router is: 1.0.20

Bug Report

Current Behavior:

$onInit is called twice when componentProvider is used.

Expected Behavior:

$onInit should be called once.

Link to Plunker or stackblitz that reproduces the issue:

Navigating to about fires $onInit twice (componentProvider ). Home only once (component).

https://stackblitz.com/edit/ui-router-angularjs-g5wlce?file=app.js

This issue have been introduced recently, I think it worked in 1.0.17.
mlnkw added a commit to mlnkw/ui-router that referenced this issue Jun 9, 2019
@mlnkw
fix(viewDirective): add check for componentProvider
f087d5e 
avoid extra trigger for $onInit (fixing angular-ui#3735)
mlnkw added a commit to mlnkw/ui-router that referenced this issue Jun 9, 2019
@mlnkw
tests(viewDirective): add check for componentProvider
f772928 
check extra trigger for $onInit (angular-ui#3735)
@N1ck
Copy link

N1ck commented Jul 28, 2019 •
edited
Loading

#3779 appears to fix this issue.

christopherthielen pushed a commit that referenced this issue Sep 3, 2019
@mlnkw @christopherthielen
fix(viewDirective): add check for componentProvider, avoid extra trig…
c3e87ad 
…ger for $onInit (fixing #3735) (#3779)
@snyk-bot snyk-bot mentioned this issue Oct 21, 2019
Open
@stale
Copy link

stale bot commented Jan 24, 2020

This issue has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs.

This does not mean that the issue is invalid. Valid issues
may be reopened.

Thank you for your contributions.

@stale stale bot added the stale label Jan 24, 2020
@stale stale bot closed this as completed Feb 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@N1ck @valterkraemer