Fix column resets to colDef width on data update #520
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok. I'll test this when I get home. It makes sense cause if the user changes the column width even for column widths that have a "", the "" should be replaced by the new width. |
|
So unfortunately by doing this the ng-grid watcher for columndefs will get fired and it will rebuild the grid. Will look into this more. |
Merged
jonricaurte
added a commit
that referenced
this pull request
Jul 1, 2013
Now if user changes column widths, *s and percentages will not be taken into account so column widths stay the same when grid data is being updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue where if a column was resized and then the data updated causing the watch event to fire, the width of the column would be reset to the width of the columnDef which makes for a poor user experience. This simple fix also sets the width in the columnDef allowing it to maintain the same width