Differ AudioManager retrieval to whenever AudioFocusManagement is req… #1616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icbaker
reviewed
Aug 14, 2024
| @@ -455,6 +453,13 @@ private void executePlayerCommand(@PlayerCommand int playerCommand) { | |||
| } | |||
| } | |||
|
|
|||
| private AudioManager getAudioManager() { | |||
| if (audioManager == null) { | |||
There was a problem hiding this comment.
NIt: you can use Guava's Suppliers.memoize for this, to avoid manually needing to check for null, so change private final AudioManager audioManager; above to private final Supplier<AudioManager> audioManager;, change the instantiation to:
this.audioManager =
Suppliers.memoize(() -> checkNotNull(
(AudioManager) context.getApplicationContext().getSystemService(Context.AUDIO_SERVICE)));
And then change the usage sites from audioManager to audioManager.get()
Maybe change the field name to audioManagerSupplier too - up to you.
There was a problem hiding this comment.
Good suggestion. Will change accordingly
|
I'm going to send this for internal review now. You may see some more commits being added as I make changes in response to review feedback. Please refrain from pushing any more substantive changes as it will complicate the internal review - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…uired