-
Notifications
You must be signed in to change notification settings - Fork 378
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
The first has a string genre, and various other values set, generated from `sample.mp4` with the command below [1]. The second has a numeric genre, to test `gnre` atom parsing. This parsing is currently broken, the fix is in a follow-up change. This file was also generated from `sample.mp4` with the command below [2]. This change also includes `CommentFrame.text` in its `toString` representation, otherwise there's no difference between e.g. different levels of `ITUNESADVISORY` in the extractor dump files. Issue: #1305 ----- [1] ```shell $ AP_PADDING="DEFAULT_PAD=0" \ AtomicParsley sample.mp4 \ --artist "Test Artist" \ --album "Test Album" \ --tracknum 2/12 \ --disk 2/3 \ --year 2024 \ --genre "Gorpcore" \ --bpm 120 \ --compilation true \ --advisory clean \ --gapless true \ --sortOrder artist "Sorting Artist" \ --sortOrder album "Sorting Album" \ --preventOptimizing \ -o sample_with_metadata.mp4 ``` [2] ```shell $ AP_PADDING="DEFAULT_PAD=0" \ AtomicParsley sample.mp4 \ --genre "Metal" \ --preventOptimizing \ -o sample_with_numeric_genre.mp4 ``` PiperOrigin-RevId: 628345458
- Loading branch information
1 parent
acb3a54
commit d76ee54
Showing
23 changed files
with
4,172 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.