-
Notifications
You must be signed in to change notification settings - Fork 378
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add ID3
TCON
genre to MP3 test samples
This change adds a 'free-form' text genre to the existing `bear-id3.mp3` sample, and adds a new sample with a 'numeric' genre ([9 is Metal](https://mutagen-specs.readthedocs.io/en/latest/id3/id3v2.4.0-frames.html#appendix-a-genre-list-from-id3v1)). The samples were modified with: ```shell $ id3edit --set-genre "Gorpcore" bear-id3.mp3 $ id3edit --set-genre "9" bear-id3-numeric-genre.mp3 ``` Reading the numeric genre with `exiftool` shows the mapping back to 'Metal': ``` $ exiftool bear-id3-numeric-genre.mp3 | grep Genre Genre : Metal ``` The playback dumps don't contain the genre because it's not yet propagated to `MediaMetadata.genre`. That is done in a follow-up change. Issue: #1305 PiperOrigin-RevId: 629043506
- Loading branch information
1 parent
d292f80
commit b0e4817
Showing
20 changed files
with
2,768 additions
and
45 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
libraries/test_data/src/test/assets/extractordumps/mp3/bear-id3-disabled.0.dump
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
libraries/test_data/src/test/assets/extractordumps/mp3/bear-id3-disabled.1.dump
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
libraries/test_data/src/test/assets/extractordumps/mp3/bear-id3-disabled.2.dump
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
libraries/test_data/src/test/assets/extractordumps/mp3/bear-id3-disabled.3.dump
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 4 additions & 4 deletions
8
libraries/test_data/src/test/assets/extractordumps/mp3/bear-id3-disabled.unknown_length.dump
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.