[BasicSample] Updates to AGP 8.3 (#52)

* Update ProfileObservableViewModel.kt * Update build.gradle * Update gradle-wrapper.properties * Update build.gradle * Update BasicSample.yaml
android · Mar 6, 2024 · b6ef92f · b6ef92f
1 parent d236366
commit b6ef92f
Show file tree

Hide file tree

Showing 5 changed files with 13 additions and 8 deletions.
diff --git a/.github/workflows/BasicSample.yaml b/.github/workflows/BasicSample.yaml
@@ -27,11 +27,11 @@ jobs:
       - name: Copy CI gradle.properties
         run: mkdir -p ~/.gradle ; cp .github/ci-gradle.properties ~/.gradle/gradle.properties
 
-      - name: Set up JDK 11
-        uses: actions/setup-java@v3
+      - name: Set up JDK 17
+        uses: actions/setup-java@v4
         with:
           distribution: 'zulu'
-          java-version: 11
+          java-version: 17
 
       - name: Generate cache key
         run: ./scripts/checksum.sh $SAMPLE_PATH checksum.txt
@@ -68,4 +68,4 @@ jobs:
         uses: actions/upload-artifact@v3
         with:
           name: build-reports-BasicSample
-          path: ${{ env.SAMPLE_PATH }}/app/build/reports
+          path: ${{ env.SAMPLE_PATH }}/app/build/reports
diff --git a/BasicSample/app/build.gradle b/BasicSample/app/build.gradle
@@ -21,6 +21,7 @@ apply plugin: 'kotlin-android'
 apply plugin: 'kotlin-kapt'
 
 android {
+    namespace 'com.example.android.databinding.basicsample'
     compileSdkVersion rootProject.compileSdkVersion
     defaultConfig {
         applicationId "com.example.android.databinding.basicsample"
@@ -40,6 +41,10 @@ android {
     buildFeatures {
         dataBinding true
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_17
+        targetCompatibility JavaVersion.VERSION_17
+    }    
 }
 
 dependencies {

diff --git a/.../main/java/com/example/android/databinding/basicsample/data/ProfileObservableViewModel.kt b/.../main/java/com/example/android/databinding/basicsample/data/ProfileObservableViewModel.kt
@@ -20,8 +20,8 @@ import androidx.databinding.Bindable
 import androidx.databinding.ObservableField
 import androidx.databinding.ObservableInt
 import androidx.lifecycle.LiveData
+import androidx.lifecycle.map
 import androidx.lifecycle.MutableLiveData
-import androidx.lifecycle.Transformations
 import androidx.lifecycle.ViewModel
 import com.example.android.databinding.basicsample.BR
 import com.example.android.databinding.basicsample.util.ObservableViewModel
@@ -41,7 +41,7 @@ class ProfileLiveDataViewModel : ViewModel() {
     val likes: LiveData<Int> = _likes
 
     // popularity is exposed as LiveData using a Transformation instead of a @Bindable property.
-    val popularity: LiveData<Popularity> = Transformations.map(_likes) {
+    val popularity: LiveData<Popularity> = _likes.map {
         when {
             it > 9 -> Popularity.STAR
             it > 4 -> Popularity.POPULAR

diff --git a/BasicSample/build.gradle b/BasicSample/build.gradle
@@ -27,7 +27,7 @@ buildscript {
         activityVersion = '1.6.1'
         constraintLayoutVersion = '2.1.4'
         espressoVersion = '3.5.1'
-        gradleVersion = '7.4.0'
+        gradleVersion = '8.3.0'
         junitVersion = '4.13.2'
         hamcrestVersion = '1.3'
         kotlinVersion = '1.8.0'

diff --git a/BasicSample/gradle/wrapper/gradle-wrapper.properties b/BasicSample/gradle/wrapper/gradle-wrapper.properties
@@ -1,5 +1,5 @@
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.4-bin.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists