Added window insets to the the main screen #1451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the headder and the body (FlowRow) are sibling elements, we have to explicitly exclude the top inset, which we get by combining the bottom and the sides (horizontal). Tested with all the developer options notch settings and with both gesture nav and 3 button nav. I did not override the navigationBarStyle since the default actually seems to work well. With three button nav, it has a partially transparent light background that helps the buttons stand out when content is behind them. With gesture nav, the bar stands out enough on its own. This fixes #1450.
IanGClifton
requested review from
simona-anomis and
riggaroo
and removed request for
simona-anomis
riggaroo
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the headder and the body (FlowRow) are sibling elements, we have to explicitly exclude the top inset, which we get by combining the bottom and the sides (horizontal). Tested with all the developer options notch settings and with both gesture nav and 3 button nav.
I did not override the navigationBarStyle since the default actually seems to work well. With three button nav, it has a partially transparent light background that helps the buttons stand out when content is behind them. With gesture nav, the bar stands out enough on its own.
This fixes #1450.