Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Gutenberg packages after v12.4.1 release #6858

Closed
wants to merge 10 commits into from

Conversation

westonruter
Copy link
Member

No description provided.

@westonruter westonruter added the dependencies Pull requests that update a dependency file label Jan 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2022

Plugin builds for ec9dea3 are ready 🛎️!

…tenberg-v12.4.1-packages

* 'develop' of github.com:ampproject/amp-wp:
  Bump node-fetch from 2.6.1 to 2.6.7 in /.github/actions/draft-release
  Bump lint-staged from 11.2.6 to 12.3.3
  Bump mustache/mustache from 2.13.0 to 2.14.1
  Bump cweagans/composer-patches from 1.7.1 to 1.7.2
  Bump follow-redirects from 1.14.5 to 1.14.7
  Bump webpackbar from 5.0.0-3 to 5.0.2
@codecov
Copy link

codecov bot commented Feb 2, 2022

Codecov Report

Merging #6858 (ec9dea3) into develop (c7a983c) will decrease coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##             develop    #6858      +/-   ##
=============================================
- Coverage      78.55%   77.81%   -0.75%     
  Complexity      6767     6767              
=============================================
  Files            202      267      +65     
  Lines          20427    21546    +1119     
=============================================
+ Hits           16046    16765     +719     
- Misses          4381     4781     +400     
Flag Coverage Δ
javascript 64.25% <ø> (?)
php 78.55% <ø> (ø)
unit 78.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
assets/src/block-validation/store/index.js 97.82% <ø> (ø)
assets/src/components/clipboard-button/index.js 50.00% <ø> (ø)
assets/src/components/error-screen/index.js 66.66% <ø> (ø)
...s/src/components/options-context-provider/index.js 2.17% <ø> (ø)
...src/components/site-scan-context-provider/index.js 34.48% <ø> (ø)
...sets/src/components/user-context-provider/index.js 3.03% <ø> (ø)
...sets/src/onboarding-wizard/components/nav/index.js 100.00% <ø> (ø)
...g-wizard/components/navigation-context-provider.js 85.00% <ø> (ø)
...idation/hooks/use-errors-fetching-state-changes.js 100.00% <0.00%> (ø)
assets/src/components/list-items/index.js 100.00% <0.00%> (ø)
... and 63 more

@westonruter
Copy link
Member Author

The E2E test is failing due to the .editor-post-preview element being after the .amp-wrapper-post-preview element, whereas previously it was before (and it is being inserted as such). I saw this locally as well for a bit, but now I don't any longer 😕

@westonruter
Copy link
Member Author

In testing this with Gutenberg 12.5, it seems the problem is that WrappedAmpPreviewButton is constructed before the .editor-post-preview element has been added to the DOM, so this.postPreviewButton is null here:

this.postPreviewButton = document.querySelector( `.${ POST_PREVIEW_CLASS }` );

@westonruter westonruter added this to the v2.2.1 milestone Feb 2, 2022
@westonruter
Copy link
Member Author

I've merged the changes here into #6881, the update to Gutenberg v12.5.0.

@westonruter westonruter closed this Feb 3, 2022
@westonruter westonruter removed this from the v2.2.1 milestone Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants