Improvements for Showing Storage Info

amitjoy · Jul 13, 2023 · 47eb5d0 · 47eb5d0
1 parent 53affba
commit 47eb5d0
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/com.osgifx.console.agent/src/main/java/com/osgifx/console/agent/admin/XBundleAdmin.java b/com.osgifx.console.agent/src/main/java/com/osgifx/console/agent/admin/XBundleAdmin.java
@@ -141,12 +141,12 @@ private static long getStorageSize(final Bundle bundle) {
         final String        bsn           = bundle.getSymbolicName();
         if (bundleContext == null) {
             logger.atDebug().msg("Bundle context is null for '{}'").arg(bsn).log();
-            return -1;
+            return -1L;
         }
         final File storage = bundleContext.getDataFile("");
         if (storage == null) {
             logger.atDebug().msg("Bundle storage is null for '{}'").arg(bsn).log();
-            return -1;
+            return -1L;
         }
         return storage.length();
     }

diff --git a/...ole.ui.bundles/src/main/java/com/osgifx/console/ui/bundles/BundleDetailsFxController.java b/...ole.ui.bundles/src/main/java/com/osgifx/console/ui/bundles/BundleDetailsFxController.java
@@ -253,6 +253,9 @@ private String formatLastModified(final long lastModified) {
     }
 
     private String humanReadableByteCount(long bytes) {
+        if (bytes == -1) {
+            return "<IGNORED>";
+        }
         if (-1000 < bytes && bytes < 1000) {
             return bytes + " B";
         }