Add optional nanos argument to uuid6 and uuid7
#51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aminalaee
reviewed
Jun 14, 2024
| year=2024, month=1, day=2, hour=3, minute=4, second=5, microsecond=123000 | ||
| ) | ||
| uuid = uuid_utils.uuid7(int(ts.timestamp()), ts.microsecond * 1_000) | ||
| assert uuid.timestamp == int(ts.timestamp() * 1000) |
There was a problem hiding this comment.
Just an FYI, I changed your test to use the timestamp property of the UUID which is an extra property compared to the stdlib.
There was a problem hiding this comment.
Probably a good idea to add documentation to this project 😅
aminalaee
changed the title
nanos to uuid6 and uuid7
aminalaee
changed the title
nanos to uuid6 and uuid7nanos argument to uuid6 and uuid7
aminalaee
approved these changes
Jun 14, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to test a round trip with full
datetimeprecision of microseconds but I'm unsure how to reconstitute the sub millisecond parts, I tried to readrand_abut never managed to get it to match my numbers.