Skip to content
This repository has been archived by the owner on Sep 19, 2024. It is now read-only.

chore: Add Data binding #71

Merged
merged 14 commits into from
Jul 8, 2019
Merged

Conversation

ajay-prabhakar
Copy link
Member

Fixed #20

Changes: Changed All layouts into data binding layout

@auto-label auto-label bot added the chore label Jul 4, 2019
Copy link
Member

@yashk2000 yashk2000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve the travis build error please @Chromicle

@immadisairaj immadisairaj self-requested a review July 5, 2019 16:36
Copy link
Member

@immadisairaj immadisairaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once can you check all the indentations

if (donatePaid.isChecked() && donateNotPaid.isChecked()) {
flag = 5;
}
readAllBinding.listView.setAdapter(adapter);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indentation

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think everywhere indentation is correct, I run spotless also for checking It didn't give me any errors

@immadisairaj
Copy link
Member

@Chromicle also it would be better if you add this in README also

@ajay-prabhakar
Copy link
Member Author

ajay-prabhakar commented Jul 8, 2019

@Chromicle also it would be better if you add this in README also

I will do that now 👍

@immadisairaj immadisairaj merged commit bdc8f67 into amfoss:development Jul 8, 2019
@ajay-prabhakar ajay-prabhakar deleted the Databinding branch July 15, 2019 16:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data Binding
3 participants