This repository has been archived by the owner on Sep 19, 2024. It is now read-only.
fixes #12: It will be better to restrict user to add either "user ID" or "name", without leaving both details empty #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yashk2000
suggested changes
Jun 10, 2019
Done :) |
yashk2000
approved these changes
Jun 10, 2019
|
@mustaqmustu thanks. |
ajay-prabhakar
suggested changes
Jun 10, 2019
| @@ -93,18 +93,23 @@ public void onClick(View v) { | |||
| insert.setOnClickListener(new View.OnClickListener() { | |||
| @Override | |||
| public void onClick(View view) { | |||
| id = id + uid1ET.getText().toString(); | |||
| id = uid1ET.getText().toString(); | |||
There was a problem hiding this comment.
Please revert the change here as by adding id to we will know the type whether it is Donation or Registration then check if the length equals to 3
There was a problem hiding this comment.
@mustaqmustu I did not notice that change. Please revert that in another pr ASAP.
There was a problem hiding this comment.
I reverted the PR please make another PR
|
You can simply revert the merged PR by using the revert button (below this comment), instead of opening a new PR. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #12
Changes: changed insertData.java file.
Screenshots of the change:
