Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(scripts): drop-module #75

Merged
merged 3 commits into from
Mar 18, 2020
Merged

fix(scripts): drop-module #75

merged 3 commits into from
Mar 18, 2020

Conversation

anescobar1991
Copy link
Member

@anescobar1991 anescobar1991 commented Mar 17, 2020

was previously not working as it was not updated to account for new module map shape

With this change npm run drop-module works again!

Description

Update one-app-bundler to fix the drop-module npm script.
See americanexpress/one-app-cli#35

Motivation and Context

npm run drop-module was not previously working, now it is.

How Has This Been Tested?

Validated that npm run drop-module works again.

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

They can use npm run drop-module again!

was previously not working as it was not updated to account for new module map shape
@anescobar1991 anescobar1991 requested a review from a team as a code owner March 17, 2020 21:23
@oneamexbot
Copy link
Contributor

oneamexbot commented Mar 17, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 112.6KB 31.4KB
runtime.js 15KB 5.3KB
vendors.js 128.1KB 37.9KB
app~vendors.js 403.5KB 105.2KB
legacy/app.js 119.4KB 33KB
legacy/runtime.js 15KB 5.3KB
legacy/vendors.js 163KB 44.8KB
legacy/app~vendors.js 409.8KB 106.9KB

Generated by 🚫 dangerJS against bef0001

@JamesSingleton JamesSingleton merged commit 8e9de45 into master Mar 18, 2020
@JamesSingleton JamesSingleton deleted the bugfix/drop-module branch March 18, 2020 16:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants