This repository has been archived by the owner on May 3, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 85
chore(logging): remove start() on oneAppDevCdnSpinner #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes watchLocalModules.spec.js silently failing when you run the test individually. Furthermore, it is not enabled on like 97.
📊 Bundle Size Report
|
JAdshead
approved these changes
Mar 12, 2020
Francois-Esquire
approved these changes
Mar 12, 2020
@@ -36,7 +36,7 @@ function createSpinner(opts) { | |||
const oneAppDevCdnSpinner = createSpinner({ | |||
text: 'Starting one-app-dev-cdn server...', | |||
spinner: 'bouncingBar', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you need to add the option isEnabled: false
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure, would like to get input from @10xLaCroixDrinker or @mtomcal on this part
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fixes watchLocalModules.spec.js silently failing when you run the test individually. Furthermore, it is not enabled on like 97.
Motivation and Context
It fixes a unit test that was silently failing. If you run the unit tests all together it will pass. However, if you run this test by itself, it will fail.
How Has This Been Tested?
Types of Changes
Checklist:
What is the Impact to Developers Using One App?