Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

chore(logging): remove start() on oneAppDevCdnSpinner #56

Merged
merged 10 commits into from
Mar 19, 2020

Conversation

JamesSingleton
Copy link
Contributor

@JamesSingleton JamesSingleton commented Mar 6, 2020

Description

This fixes watchLocalModules.spec.js silently failing when you run the test individually. Furthermore, it is not enabled on like 97.

Motivation and Context

It fixes a unit test that was silently failing. If you run the unit tests all together it will pass. However, if you run this test by itself, it will fail.

How Has This Been Tested?

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

This fixes watchLocalModules.spec.js silently failing when you run the test individually. Furthermore, it is not enabled on like 97.
@JamesSingleton JamesSingleton requested a review from a team as a code owner March 6, 2020 23:22
@oneamexbot
Copy link
Contributor

oneamexbot commented Mar 6, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 112.6KB 31.4KB
runtime.js 15KB 5.3KB
vendors.js 128.1KB 37.9KB
app~vendors.js 403.5KB 105.2KB
legacy/app.js 119.4KB 33KB
legacy/runtime.js 15KB 5.3KB
legacy/vendors.js 163KB 44.8KB
legacy/app~vendors.js 409.8KB 106.9KB

Generated by 🚫 dangerJS against 409ade0

@@ -36,7 +36,7 @@ function createSpinner(opts) {
const oneAppDevCdnSpinner = createSpinner({
text: 'Starting one-app-dev-cdn server...',
spinner: 'bouncingBar',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you need to add the option isEnabled: false?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure, would like to get input from @10xLaCroixDrinker or @mtomcal on this part

@JamesSingleton JamesSingleton merged commit 8949065 into master Mar 19, 2020
@JamesSingleton JamesSingleton deleted the chore/logging-dev-formatters branch March 19, 2020 20:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants