This repository has been archived by the owner on May 3, 2024. It is now read-only.
chore(template): add pull request template #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📊 Bundle Size Report
|
anescobar1991
suggested changes
Feb 27, 2020
.github/pull_request_template.md
Outdated
| - [ ] This change impacts HTTP headers. | ||
| - [ ] This change has new infrastructure requirements. | ||
| - [ ] This change requires additional environment variables. | ||
| - [ ] I have added the Apache 2.0 license to any new files created. |
There was a problem hiding this comment.
Should be license header.
.github/pull_request_template.md
Outdated
| - [ ] This change requires a performance test prior to merging. | ||
| - [ ] This change impacts caching. | ||
| - [ ] This change impacts HTTP headers. | ||
| - [ ] This change has new infrastructure requirements. |
There was a problem hiding this comment.
This should be explained in more detail
There was a problem hiding this comment.
Yes it should. Any input here as it was a question in the preflight checklist and wasn't sure.
.github/pull_request_template.md
Outdated
| - [ ] I have added the Apache 2.0 license to any new files created. | ||
|
|
||
| ## What is the Impact to Developers Using the App? | ||
| <!--- Please describe how your changes impacts developers using the app. --> |
.github/pull_request_template.md
Outdated
| - [ ] These changes should be applied to a maintenance branch. | ||
| - [ ] This change requires cross browser checks. | ||
| - [ ] This change requires a performance test prior to merging. | ||
| - [ ] This change impacts caching. |
There was a problem hiding this comment.
Should specify that you mean caching for client browsers.
.github/pull_request_template.md
Outdated
| - [ ] I have updated the documentation accordingly. | ||
| - [ ] These changes should be applied to a maintenance branch. | ||
| - [ ] This change requires cross browser checks. | ||
| - [ ] This change requires a performance test prior to merging. |
There was a problem hiding this comment.
You should specify if you mean client side of server side perf test.
There was a problem hiding this comment.
What do we mean in the current Preflight Checklist?
.github/pull_request_template.md
Outdated
| - [ ] This change impacts caching. | ||
| - [ ] This change impacts HTTP headers. | ||
| - [ ] This change has new infrastructure requirements. | ||
| - [ ] This change requires additional environment variables. |
There was a problem hiding this comment.
How about This change adds additional environment variable requirements for One App users?
JAdshead
suggested changes
Feb 27, 2020
JamesSingleton
force-pushed
the
chore/pull-request-template
branch
from
e72af28
to
86d7591
Compare
added 2 commits
February 28, 2020 13:11
This is much more reliable and better state management
JamesSingleton
commented
Feb 29, 2020
| .on('close', () => res(bytesWritten)) | ||
| .pipe(byteCounter) | ||
| .on('error', rej); | ||
| pipeline( |
There was a problem hiding this comment.
This suggestion actually came from James Snell. He is on the Node.js TSC.
JAdshead
suggested changes
Mar 3, 2020
10xLaCroixDrinker
previously requested changes
Mar 3, 2020
Co-Authored-By: Jimmy King <jimmy.king@aexp.com>
JAdshead
approved these changes
Mar 3, 2020
mtomcal
approved these changes
Mar 3, 2020
anescobar1991
approved these changes
Mar 4, 2020
JamesSingleton
dismissed
10xLaCroixDrinker’s stale review
This was taken care of already
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a pull request template for newly created PRs to get more information about the PR being opened.