Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

docs(readme): update readme for generator #39

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Conversation

nellyk
Copy link
Contributor

@nellyk nellyk commented Feb 24, 2020

Added NODE_ENV as it is required for the one-app-generator to create a module

@nellyk nellyk requested a review from a team as a code owner February 24, 2020 11:47
@oneamexbot
Copy link
Contributor

oneamexbot commented Feb 24, 2020

☑️ Preflight Checklist:

All questions must be addressed before this PR can be merged.

  • What is the communication plan for this change?
  • Does any documentation need to be updated or added to account for this change? If so was it done already?
  • What is the motivation for this change?
  • Should these changes also be applied to a maintenance branch or any other long lived branch?
  • How was this change tested?
  • Does this change require cross browser checks? Why or why not?
  • Does this change require a performance test prior to merging? Why or why not?
  • Could this be considered a breaking change? Why or why not?
  • Does the change impact caching?
  • Does the change impact HTTP headers?
  • Does the change have any new infrastructure requirements?
  • Does the change affect other versions of the app?
  • Does the change require additional environment variables?
  • What is the impact to developers using the app?
  • What is the change to the size of assets?
  • Should integration tests be added to protect against future regressions on this change?

Generated by 🚫 dangerJS against 63c5f00

@10xLaCroixDrinker
Copy link
Member

Commit type should be docs

@nellyk nellyk changed the title chore(readme): update readme for generator doc(readme): update readme for generator Feb 25, 2020
@nellyk nellyk changed the title doc(readme): update readme for generator docs(readme): update readme for generator Feb 25, 2020
@nellyk
Copy link
Contributor Author

nellyk commented Feb 25, 2020

What is the communication plan for this change?N/A
Does any documentation need to be updated or added to account for this change? If so was it done already?N/A
What is the motivation for this change? For ensure correct installation when creating one-app modules
Should these changes also be applied to a maintenance branch or any other long lived branch?
How was this change tested?N/A
Does this change require cross browser checks? Why or why not?N/A
Does this change require a performance test prior to merging? Why or why not?N/A
Could this be considered a breaking change? Why or why not?Nope, updating the docs
Does the change impact caching?N/A
Does the change impact HTTP headers?N/A
Does the change have any new infrastructure requirements?N/A
Does the change affect other versions of the app?N/A
Does the change require additional environment variables?N/A
What is the impact to developers using the app?N/A
What is the change to the size of assets?N/A
Should integration tests be added to protect against future regressions on this change?N/A

@anescobar1991
Copy link
Member

Good catch @nellyk!

@anescobar1991 anescobar1991 merged commit 752140f into master Feb 27, 2020
@anescobar1991 anescobar1991 deleted the nellyk-patch-1 branch February 27, 2020 02:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants