You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on May 3, 2024. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What is the communication plan for this change?N/A
Does any documentation need to be updated or added to account for this change? If so was it done already?N/A
What is the motivation for this change? For ensure correct installation when creating one-app modules
Should these changes also be applied to a maintenance branch or any other long lived branch?
How was this change tested?N/A
Does this change require cross browser checks? Why or why not?N/A
Does this change require a performance test prior to merging? Why or why not?N/A
Could this be considered a breaking change? Why or why not?Nope, updating the docs
Does the change impact caching?N/A
Does the change impact HTTP headers?N/A
Does the change have any new infrastructure requirements?N/A
Does the change affect other versions of the app?N/A
Does the change require additional environment variables?N/A
What is the impact to developers using the app?N/A
What is the change to the size of assets?N/A
Should integration tests be added to protect against future regressions on this change?N/A
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
None yet
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added NODE_ENV as it is required for the one-app-generator to create a module