Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

test(integration): domain scanning #35

Merged
merged 4 commits into from
Feb 25, 2020
Merged

Conversation

JAdshead
Copy link
Contributor

No description provided.

@JAdshead JAdshead requested a review from a team as a code owner February 11, 2020 20:17
@oneamexbot
Copy link
Contributor

oneamexbot commented Feb 11, 2020

☑️ Preflight Checklist:

All questions must be addressed before this PR can be merged.

  • What is the communication plan for this change?
  • Does any documentation need to be updated or added to account for this change? If so was it done already?
  • What is the motivation for this change?
  • Should these changes also be applied to a maintenance branch or any other long lived branch?
  • How was this change tested?
  • Does this change require cross browser checks? Why or why not?
  • Does this change require a performance test prior to merging? Why or why not?
  • Could this be considered a breaking change? Why or why not?
  • Does the change impact caching?
  • Does the change impact HTTP headers?
  • Does the change have any new infrastructure requirements?
  • Does the change affect other versions of the app?
  • Does the change require additional environment variables?
  • What is the impact to developers using the app?
  • What is the change to the size of assets?
  • Should integration tests be added to protect against future regressions on this change?

Generated by 🚫 dangerJS against 6b1e6fb

@JAdshead
Copy link
Contributor Author

What is the communication plan for this change?
NA
Does any documentation need to be updated or added to account for this change? If so was it done already?
Yes, has been included
What is the motivation for this change?
Provide way to test user arriving at different versions of one-app
Should these changes also be applied to a maintenance branch or any other long lived branch?
yes, done
How was this change tested?
locally, red - green
Does this change require cross browser checks? Why or why not?
no, tests only
Does this change require a performance test prior to merging? Why or why not?
no,test only
Could this be considered a breaking change? Why or why not?
no, tests only
Does the change impact caching?
no
Does the change impact HTTP headers?
no
Does the change have any new infrastructure requirements?
no
Does the change affect other versions of the app?
no
Does the change require additional environment variables?
no
What is the impact to developers using the app?
none
What is the change to the size of assets?
none
Should integration tests be added to protect against future regressions on this change?
no

@JAdshead JAdshead merged commit 27e0a5a into master Feb 25, 2020
@JAdshead JAdshead deleted the tests/scan-environment branch February 25, 2020 19:11
@nellyk nellyk added the chore label Apr 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants