Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

feat(serverError): add additional logging for server errors #282

Merged
merged 3 commits into from
Aug 21, 2020

Conversation

infoxicator
Copy link
Contributor

Logging the method, request url and the correlation_id when an error occurs.

Description

Refactored the express middleware error handler into its own file src/server/middleware/serverError and added additional information to the log

Motivation and Context

Additional error logs to help debugging

How Has This Been Tested?

Unit tests

Tested by sending a 100kb payload to the _/report/errors endpoint to trigger the entity_too_large error

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

@infoxicator infoxicator requested review from a team as code owners August 20, 2020 15:08
@oneamexbot
Copy link
Contributor

oneamexbot commented Aug 20, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 275.4KB 82.2KB
runtime.js 15KB 5.4KB
vendors.js 117.2KB 36.4KB
app~vendors.js 432.5KB 112.2KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 290.7KB 85.4KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 163.4KB 44.7KB
legacy/app~vendors.js 441.3KB 114.5KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against 6f63097

@infoxicator infoxicator merged commit 60825f8 into master Aug 21, 2020
@infoxicator infoxicator deleted the feature/additional-error-logs branch August 21, 2020 10:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants