Skip to content
This repository has been archived by the owner on May 3, 2024. It is now read-only.

fix(stateConfig): incorrect env var for dev-proxy port #209

Merged
merged 2 commits into from
Jun 24, 2020

Conversation

infoxicator
Copy link
Contributor

SERVICES_PORT envVar doesn't exist the correct one is HTTP_ONE_APP_DEV_PROXY_SERVER_PORT for the proxy server port.

Description

Motivation and Context

Fixes an issue where the port for the dev proxy server wasn't picked up due to an incorrect environment variable name

How Has This Been Tested?

Tested by passing the correct variable and now the proxy dev server starts in the desired port instead of 3002 and defaults to 3002 when the variable is not present

Types of Changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation (adding or updating documentation)
  • Dependency update

Checklist:

  • My change requires a change to the documentation and I have updated the documentation accordingly.
  • These changes should be applied to a maintenance branch.
  • This change requires cross browser checks.
  • Performance tests should be ran against the server prior to merging.
  • This change impacts caching for client browsers.
  • This change impacts HTTP headers.
  • This change adds additional environment variable requirements for One App users.
  • I have added the Apache 2.0 license header to any new files created.

What is the Impact to Developers Using One App?

No impact this fixes an issue when overriding the default port for the dev proxy server

@infoxicator infoxicator requested review from a team as code owners June 23, 2020 14:34
@oneamexbot
Copy link
Contributor

oneamexbot commented Jun 23, 2020

📊 Bundle Size Report

file name size on disk gzip
app.js 275.3KB 82.2KB
runtime.js 15KB 5.4KB
vendors.js 117.2KB 36.4KB
app~vendors.js 432.4KB 112.2KB
service-worker-client.js 17KB 5.2KB
legacy/app.js 290.6KB 85.3KB
legacy/runtime.js 15KB 5.4KB
legacy/vendors.js 163.4KB 44.7KB
legacy/app~vendors.js 441.3KB 114.5KB
legacy/service-worker-client.js 17.5KB 5.4KB

Generated by 🚫 dangerJS against 0728764

@infoxicator infoxicator merged commit 3620a1a into master Jun 24, 2020
@infoxicator infoxicator deleted the fix/services-port branch June 24, 2020 08:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants